From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH 0/2] cxgb4vf: small fixes to new driver Date: Wed, 30 Jun 2010 14:05:13 -0700 (PDT) Message-ID: <20100630.140513.171484395.davem@davemloft.net> References: <201006291552.14816.leedom@chelsio.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: leedom@chelsio.com Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:38228 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755034Ab0F3VFA (ORCPT ); Wed, 30 Jun 2010 17:05:00 -0400 In-Reply-To: <201006291552.14816.leedom@chelsio.com> Sender: netdev-owner@vger.kernel.org List-ID: I've applied both patches but you really need to fix up how you submit these changes. 1) Your Subject: line becomes the commit message header. It should be a single statement, prefixed by "xxx: " where "xxx" is the subsystem or driver you are making changes to. Here it would be "cxgb4vf: " It should not bleed into the rest of commit message body, like your's did. 2) You should not include all of the commit crap from GIT in the body of your email. I just have to edit all of that junk out before I apply your patch. A perfect email patch submission looks like this (my comments are in {} braces): From: Me Subject: [PATCH N/M] subsystem: Make whatever do whatever. { Next line is optional, it goes into your email body and is used when the patch author is someone other than the person sending the email } From: Real Author This explains what this commit message is doing. It gives code path traces, pretty ascii-art diagrams, and cross references when doing so helps other people understand the change. Signed-off-by: Real Author Signed-off-by: Me { "---" marks the end of the commit message text, afterwards you can add whatever auxiliary information you want people to know about the patch, but for whatever reason it'snt appropriate for the commit message. } --- This is some extra information I want the list to see when I post this patch. { And finally the full patch comes next. } Ok? All of the GIT tools know exactly how to pick apart the above formatted patch and apply it to the tree with the author, etc. all set properly. And this is the format output by "git send-email" so you can use it to help construct proper patch postings even if you don't want to use "git send-email" to send the email directly.