From: David Miller <davem@davemloft.net>
To: bhutchings@solarflare.com
Cc: netdev@vger.kernel.org, linux-net-drivers@solarflare.com,
sgruszka@redhat.com, amit.salecha@qlogic.com, amwang@redhat.com,
anirban.chakraborty@qlogic.com, dm@chelsio.com,
scofeldm@cisco.com, vkolluri@cisco.com, roprabhu@cisco.com,
e1000-devel@lists.sourceforge.net, buytenh@wantstofly.org,
gallatin@myri.com, brice@myri.com,
shemminger@linux-foundation.org, jgarzik@redhat.com
Subject: Re: [PATCH net-next-2.6 1/3] ethtool: Change ethtool_op_set_flags to validate flags
Date: Wed, 30 Jun 2010 14:10:27 -0700 (PDT) [thread overview]
Message-ID: <20100630.141027.219740852.davem@davemloft.net> (raw)
In-Reply-To: <1277901872.2082.10.camel@achroite.uk.solarflarecom.com>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Wed, 30 Jun 2010 13:44:32 +0100
> ethtool_op_set_flags() does not check for unsupported flags, and has
> no way of doing so. This means it is not suitable for use as a
> default implementation of ethtool_ops::set_flags.
>
> Add a 'supported' parameter specifying the flags that the driver and
> hardware support, validate the requested flags against this, and
> change all current callers to pass this parameter.
>
> Change some other trivial implementations of ethtool_ops::set_flags to
> call ethtool_op_set_flags().
>
> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
> Reviewed-by: Stanislaw Gruszka <sgruszka@redhat.com>
> Acked-by: Jeff Garzik <jgarzik@redhat.com>
Applied.
next prev parent reply other threads:[~2010-06-30 21:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-30 12:44 [PATCH net-next-2.6 1/3] ethtool: Change ethtool_op_set_flags to validate flags Ben Hutchings
2010-06-30 12:46 ` [PATCH net-next-2.6 2/3] netdev: Make ethtool_ops::set_flags() return -EINVAL for unsupported flags Ben Hutchings
2010-06-30 15:01 ` Eilon Greenstein
2010-06-30 21:10 ` David Miller
2010-06-30 12:47 ` [PATCH net-next-2.6 3/3] vmxnet3: Remove incorrect implementation of ethtool_ops::get_flags() Ben Hutchings
2010-06-30 15:44 ` [Pv-drivers] " Bhavesh Davda
2010-06-30 15:58 ` Ben Hutchings
2010-06-30 16:46 ` Bhavesh Davda
2010-06-30 21:10 ` David Miller
2010-06-30 21:10 ` David Miller [this message]
2010-07-02 16:55 ` [PATCH net-next-2.6 1/3] ethtool: Change ethtool_op_set_flags to validate flags Randy Dunlap
2010-07-03 5:07 ` David Miller
2010-07-03 19:07 ` Randy Dunlap
2010-07-03 19:21 ` Ben Hutchings
2010-07-03 19:41 ` [PATCH net-next-2.6] IB/{nes,ipoib}: Pass supported flags to ethtool_op_set_flags() Ben Hutchings
2010-07-03 20:08 ` Roland Dreier
2010-07-03 20:40 ` [PATCH net-next-2.6] IB/{nes, ipoib}: " Ben Hutchings
2010-07-04 18:48 ` [PATCH net-next-2.6] IB/{nes,ipoib}: " David Miller
2010-07-06 16:22 ` [PATCH net-next-2.6] IB/{nes, ipoib}: " Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100630.141027.219740852.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=amit.salecha@qlogic.com \
--cc=amwang@redhat.com \
--cc=anirban.chakraborty@qlogic.com \
--cc=bhutchings@solarflare.com \
--cc=brice@myri.com \
--cc=buytenh@wantstofly.org \
--cc=dm@chelsio.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=gallatin@myri.com \
--cc=jgarzik@redhat.com \
--cc=linux-net-drivers@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=roprabhu@cisco.com \
--cc=scofeldm@cisco.com \
--cc=sgruszka@redhat.com \
--cc=shemminger@linux-foundation.org \
--cc=vkolluri@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).