[PATCH 0/2] cxgb4vf: small fixes to new driver

[PATCH 0/2] cxgb4vf: small fixes to new driver

[Casey Leedom]

>From d9aed637fc8a9f1bf1bccf6f23aed0342870f868 Mon Sep 17 00:00:00 2001
From: Casey Leedom <leedom@chelsio.com>
Date: Tue, 29 Jun 2010 15:41:14 -0700
Subject: [PATCH 0/2] cxgb4vf: small fixes to new driver

  In my cxgb4vf driver testing I got very "lucky" and the use of an
incorrect shift factor just happened to work for the packet size I was
using. (sigh) (All of this happened because I had to translate our internal
version of the driver to use the different constant names used in the
kernel.org tree.)

Casey Leedom (2):
  Remove obsolete comment about the lack of a TX Timer Callback --
    which we now _do_ have ...

  Use correct shift factor for extracting the SGE DMA Ingress Padding  
    Boundary.  Was accidentally using the register field's shift which
    was close enough (4 instead of the propper value of 5) that it
    actually sort of worked for various packet sizes ...

 drivers/net/cxgb4vf/sge.c |   15 ++-------------
 1 files changed, 2 insertions(+), 13 deletions(-)

Re: [PATCH 0/2] cxgb4vf: small fixes to new driver

[David Miller]

I've applied both patches but you really need to fix up how you
submit these changes.

1) Your Subject: line becomes the commit message header.

   It should be a single statement, prefixed by "xxx: "
   where "xxx" is the subsystem or driver you are making
   changes to.  Here it would be "cxgb4vf: "

   It should not bleed into the rest of commit message body, like
   your's did.

2) You should not include all of the commit crap from GIT in the body
   of your email.  I just have to edit all of that junk out before I
   apply your patch.

A perfect email patch submission looks like this (my comments are in
{} braces):

From: Me <me@wherever.com>
Subject: [PATCH N/M] subsystem: Make whatever do whatever.

{ Next line is optional, it goes into your email body and is used
  when the patch author is someone other than the person sending
  the email }

From: Real Author <cooldude@wherever.com>

This explains what this commit message is doing.

It gives code path traces, pretty ascii-art diagrams, and cross
references when doing so helps other people understand the change.

Signed-off-by: Real Author <cooldude@wherever.com>
Signed-off-by: Me <me@wherever.com>

{ "---" marks the end of the commit message text, afterwards you
   can add whatever auxiliary information you want people to know about
   the patch, but for whatever reason it'snt appropriate for the
   commit message. }

---

This is some extra information I want the list to see when I post
this patch.

{ And finally the full patch comes next. }

Ok?  All of the GIT tools know exactly how to pick apart the above
formatted patch and apply it to the tree with the author, etc. all
set properly.

And this is the format output by "git send-email" so you can use it
to help construct proper patch postings even if you don't want to
use "git send-email" to send the email directly.

Re: [PATCH 0/2] cxgb4vf: small fixes to new driver

[Casey Leedom]

| From: David Miller <davem@davemloft.net>
| Date: Wednesday, June 30, 2010 02:05 pm
| 
| I've applied both patches but you really need to fix up how you
| submit these changes.

  Thanks David.  I won't submit any more patches till I get my local git patch 
experts to vet the results.  You shouldn't be asked to do such mechanical patch 
fixups.  I appreciate your time in describing this.  Thanks!

Hoping not to be a Patch Bozo in future submissions,
Casey

P.S. Is the below in a FAQ and/or Wiki somewhere?  if not, I think it would make 
a valuable addition.  (And if it already is in a FAQ/Wiki then I'm even more of 
a Patch Bozo ...)

| 1) Your Subject: line becomes the commit message header.
| 
|    It should be a single statement, prefixed by "xxx: "
|    where "xxx" is the subsystem or driver you are making
|    changes to.  Here it would be "cxgb4vf: "
| 
|    It should not bleed into the rest of commit message body, like
|    your's did.
| 
| 2) You should not include all of the commit crap from GIT in the body
|    of your email.  I just have to edit all of that junk out before I
|    apply your patch.
| 
| A perfect email patch submission looks like this (my comments are in
| {} braces):
| 
| From: Me <me@wherever.com>
| Subject: [PATCH N/M] subsystem: Make whatever do whatever.
| 
| { Next line is optional, it goes into your email body and is used
|   when the patch author is someone other than the person sending
|   the email }
| 
| From: Real Author <cooldude@wherever.com>
| 
| This explains what this commit message is doing.
| 
| It gives code path traces, pretty ascii-art diagrams, and cross
| references when doing so helps other people understand the change.
| 
| Signed-off-by: Real Author <cooldude@wherever.com>
| Signed-off-by: Me <me@wherever.com>
| 
| { "---" marks the end of the commit message text, afterwards you
|    can add whatever auxiliary information you want people to know about
|    the patch, but for whatever reason it'snt appropriate for the
|    commit message. }
| 
| ---
| 
| This is some extra information I want the list to see when I post
| this patch.
| 
| { And finally the full patch comes next. }
| 
| Ok?  All of the GIT tools know exactly how to pick apart the above
| formatted patch and apply it to the tree with the author, etc. all
| set properly.
| 
| And this is the format output by "git send-email" so you can use it
| to help construct proper patch postings even if you don't want to
| use "git send-email" to send the email directly.

Re: [PATCH 0/2] cxgb4vf: small fixes to new driver

[David Miller]

From: Casey Leedom <leedom@chelsio.com>
Date: Wed, 30 Jun 2010 14:13:42 -0700

> P.S. Is the below in a FAQ and/or Wiki somewhere?  if not, I think it would make 
> a valuable addition.  (And if it already is in a FAQ/Wiki then I'm even more of 
> a Patch Bozo ...)

See the "DISCUSSION" section of "git help am"