From: Simon Horman <horms@verge.net.au>
To: Andreas Steffen <andreas.steffen@hsr.ch>
Cc: "Steffen Andreas (asteffen@hsr.ch)" <asteffen@hsr.ch>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
jamal <hadi@cyberus.ca>
Subject: Re: static inline int xfrm_mark_get() broken
Date: Wed, 30 Jun 2010 16:01:21 +0900 [thread overview]
Message-ID: <20100630070121.GA26582@verge.net.au> (raw)
In-Reply-To: <4C2AD009.40306@hsr.ch>
On Wed, Jun 30, 2010 at 07:03:05AM +0200, Andreas Steffen wrote:
> Hello Simon,
>
> actually I don't care how this bug is going to be fixed, but with
> sizeof(struct xfrm_mark) I'm dead certain that both the mark
> value and mask are being copied. Actually in the next inline
> function right below sizeof(struct xfrm_mark) is used, too:
>
> static inline int xfrm_mark_put(struct sk_buff *skb, struct xfrm_mark *m)
> {
> if (m->m | m->v)
> NLA_PUT(skb, XFRMA_MARK, sizeof(struct xfrm_mark), m);
> return 0;
In that case I withdraw my suggestion.
prev parent reply other threads:[~2010-06-30 7:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-28 18:46 static inline int xfrm_mark_get() broken Andreas Steffen
2010-06-30 4:46 ` Simon Horman
2010-06-30 5:03 ` Andreas Steffen
2010-06-30 7:01 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100630070121.GA26582@verge.net.au \
--to=horms@verge.net.au \
--cc=andreas.steffen@hsr.ch \
--cc=asteffen@hsr.ch \
--cc=hadi@cyberus.ca \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).