From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Andrew Gallatin <gallatin@myri.com>
Cc: netdev@vger.kernel.org, Amerigo Wang <amwang@redhat.com>,
Brice Goglin <brice@myri.com>
Subject: Re: [PATCH -next] myri10ge: clear NETIF_F_LRO bit directly
Date: Wed, 30 Jun 2010 13:26:22 +0200 [thread overview]
Message-ID: <20100630132622.499f41a0@dhcp-lab-109.englab.brq.redhat.com> (raw)
In-Reply-To: <4C2A14CE.3090502@myri.com>
On Tue, 29 Jun 2010 11:44:14 -0400
Andrew Gallatin <gallatin@myri.com> wrote:
> Stanislaw Gruszka wrote:
> > Do not use ethtool_op_set_flags() to clear one bit in ->features.
> > Inform user about disabling LRO.
>
> Thanks.. That simplifies things nicely. But was
> direct manipulation of netdev->features ever discouraged,
> or has my use of ethtool_op_{get,set}_flags() to manipulate
> the features always been complete overkill?
It was a bit overkill. Manipulate netdev->features is fine,
many drivers do it.
> > Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
>
> Acked-by: Andrew J. Gallatin <gallatin@myri.com>
Thanks. FYI: Ben Hutchings posted other patch spread over
all drivers: http://patchwork.ozlabs.org/patch/57286/
we most likely will use it to put this myri10ge bits in.
Stanislaw
prev parent reply other threads:[~2010-06-30 11:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-29 14:37 [PATCH -next] myri10ge: clear NETIF_F_LRO bit directly Stanislaw Gruszka
2010-06-29 15:44 ` Andrew Gallatin
2010-06-30 11:26 ` Stanislaw Gruszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100630132622.499f41a0@dhcp-lab-109.englab.brq.redhat.com \
--to=sgruszka@redhat.com \
--cc=amwang@redhat.com \
--cc=brice@myri.com \
--cc=gallatin@myri.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).