From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [PATCH net-next-2.6] netfilter: remove deprecated config option NF_CT_ACCT Date: Wed, 30 Jun 2010 16:15:59 +0200 Message-ID: <20100630141559.GC2582@psychotron.brq.redhat.com> References: <20100629154507.GA5260@psychotron.brq.redhat.com> <4C2B3437.6000602@trash.net> <20100630124954.GA2582@psychotron.brq.redhat.com> <4C2B3E3D.7030804@trash.net> <20100630131153.GB2582@psychotron.brq.redhat.com> <4C2B49B9.5050302@trash.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, davem@davemloft.net, ole@ans.pl To: Patrick McHardy Return-path: Received: from mx1.redhat.com ([209.132.183.28]:18273 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756116Ab0F3OQQ (ORCPT ); Wed, 30 Jun 2010 10:16:16 -0400 Content-Disposition: inline In-Reply-To: <4C2B49B9.5050302@trash.net> Sender: netdev-owner@vger.kernel.org List-ID: Wed, Jun 30, 2010 at 03:42:17PM CEST, kaber@trash.net wrote: >Jiri Pirko wrote: >>Wed, Jun 30, 2010 at 02:53:17PM CEST, kaber@trash.net wrote: >>>Jiri Pirko wrote: >>>>Apart your patch doesn't remove option from defconfigs (not sure if that's >>>>necessary or not), your patch also do not print warning in connbytes_mt_init. >>>>That would make connbytes silently non-functional. Therefore I think my patch is >>>>better (more complete). >>>The patch I have queued is automatically enabling accounting when >>>the connbytes match is used and is printing a warning. >> >>ok, that looks fine to me. What about those config options in def_config files? > >I usually leave those for the architecture maintainers. > Ok, Thanks Patrick. Dave, please drop this patch. Thanks.