[RESEND][PATCH] cxgb4: Use kfree_skb for skb pointers

[RESEND][PATCH] cxgb4: Use kfree_skb for skb pointers

[Denis Kirjanov]

Use kfree_skb for skb pointers

Acked-by: Dimitris Michailidis <dm@chelsio.com> 
Signed-off-by: Denis Kirjanov <dkirjanov@kernel.org>
---
drivers/net/cxgb4/l2t.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/cxgb4/l2t.c b/drivers/net/cxgb4/l2t.c
index 5b990d2..e8f0f55 100644
--- a/drivers/net/cxgb4/l2t.c
+++ b/drivers/net/cxgb4/l2t.c
@@ -314,7 +314,7 @@ static void t4_l2e_free(struct l2t_entry *e)
 			struct sk_buff *skb = e->arpq_head;
 
 			e->arpq_head = skb->next;
-			kfree(skb);
+			kfree_skb(skb);
 		}
 		e->arpq_tail = NULL;
 	}

Re: [RESEND][PATCH] cxgb4: Use kfree_skb for skb pointers

[David Miller]

From: Denis Kirjanov <dkirjanov@hera.kernel.org>
Date: Thu, 1 Jul 2010 09:45:52 +0000

> Use kfree_skb for skb pointers
> 
> Acked-by: Dimitris Michailidis <dm@chelsio.com> 
> Signed-off-by: Denis Kirjanov <dkirjanov@kernel.org>

The code is completely different in this part of the driver now, this
patch does not apply.

In fact there is no reference to the string "kfree" at all in the
l2t.c file of the cxgb4 driver :)

RE: [RESEND][PATCH] cxgb4: Use kfree_skb for skb pointers

[Dimitrios Michailidis]

> From: Denis Kirjanov <dkirjanov@hera.kernel.org>
> Date: Thu, 1 Jul 2010 09:45:52 +0000
> 
> > Use kfree_skb for skb pointers
> >
> > Acked-by: Dimitris Michailidis <dm@chelsio.com>
> > Signed-off-by: Denis Kirjanov <dkirjanov@kernel.org>
> 
> The code is completely different in this part of the driver now, this
> patch does not apply.
> 
> In fact there is no reference to the string "kfree" at all in the
> l2t.c file of the cxgb4 driver :)

This patch is for net-next and it should apply there, I see the wrong
kfree (there's only one kfree).  Denis didn't mention net-next, maybe
you tried to apply it to net-2.6?

Re: [RESEND][PATCH] cxgb4: Use kfree_skb for skb pointers

[David Miller]

From: "Dimitrios Michailidis" <dm@chelsio.com>
Date: Fri, 2 Jul 2010 22:51:17 -0700

> 
>> From: Denis Kirjanov <dkirjanov@hera.kernel.org>
>> Date: Thu, 1 Jul 2010 09:45:52 +0000
>> 
>> > Use kfree_skb for skb pointers
>> >
>> > Acked-by: Dimitris Michailidis <dm@chelsio.com>
>> > Signed-off-by: Denis Kirjanov <dkirjanov@kernel.org>
>> 
>> The code is completely different in this part of the driver now, this
>> patch does not apply.
>> 
>> In fact there is no reference to the string "kfree" at all in the
>> l2t.c file of the cxgb4 driver :)
> 
> This patch is for net-next and it should apply there, I see the wrong
> kfree (there's only one kfree).  Denis didn't mention net-next, maybe
> you tried to apply it to net-2.6?

Yes, I did.

That's why people should always indicate what tree a patch is for
in the subject line or similar.

Re: [RESEND][PATCH] cxgb4: Use kfree_skb for skb pointers

[Denis Kirjanov]

On 07/03/2010 10:43 AM, David Miller wrote:
> From: "Dimitrios Michailidis"<dm@chelsio.com>
> Date: Fri, 2 Jul 2010 22:51:17 -0700
>
>>
>>> From: Denis Kirjanov<dkirjanov@hera.kernel.org>
>>> Date: Thu, 1 Jul 2010 09:45:52 +0000
>>>
>>>> Use kfree_skb for skb pointers
>>>>
>>>> Acked-by: Dimitris Michailidis<dm@chelsio.com>
>>>> Signed-off-by: Denis Kirjanov<dkirjanov@kernel.org>
>>>
>>> The code is completely different in this part of the driver now, this
>>> patch does not apply.
>>>
>>> In fact there is no reference to the string "kfree" at all in the
>>> l2t.c file of the cxgb4 driver :)
>>
>> This patch is for net-next and it should apply there, I see the wrong
>> kfree (there's only one kfree).  Denis didn't mention net-next, maybe
>> you tried to apply it to net-2.6?
>
> Yes, I did.
>
> That's why people should always indicate what tree a patch is for
> in the subject line or similar.
>
Yes, I'll be more accurate next time.

Thanks.