From: David Miller <davem@davemloft.net>
To: rusty@rustcorp.com.au
Cc: netdev@vger.kernel.org, mst@redhat.com, herbert@gondor.apana.org.au
Subject: Re: [PATCH 2/2] virtio_net: fix oom handling on tx
Date: Fri, 02 Jul 2010 22:29:51 -0700 (PDT) [thread overview]
Message-ID: <20100702.222951.260082920.davem@davemloft.net> (raw)
In-Reply-To: <201007031234.01937.rusty@rustcorp.com.au>
From: Rusty Russell <rusty@rustcorp.com.au>
Date: Sat, 3 Jul 2010 12:34:01 +1000
> virtio net will never try to overflow the TX ring, so the only reason
> add_buf may fail is out of memory. Thus, we can not stop the
> device until some request completes - there's no guarantee anything
> at all is outstanding.
>
> Make the error message clearer as well: error here does not
> indicate queue full.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> (...and avoid TX_BUSY)
> Cc: stable@kernel.org # .34.x (s/virtqueue_/vi->svq->vq_ops->/)
Applied.
next prev parent reply other threads:[~2010-07-03 5:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-03 2:32 [PATCH 1/2] virtio_net: do not reschedule rx refill forever Rusty Russell
2010-07-03 2:34 ` [PATCH 2/2] virtio_net: fix oom handling on tx Rusty Russell
2010-07-03 5:29 ` David Miller [this message]
2010-07-03 5:29 ` [PATCH 1/2] virtio_net: do not reschedule rx refill forever David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100702.222951.260082920.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).