From: David Miller <davem@davemloft.net>
To: jon.mason@exar.com
Cc: netdev@vger.kernel.org, Ramkrishna.Vepa@exar.com,
Sivakumar.Subramani@exar.com, Sreenivasa.Honnur@exar.com,
mschmidt@redhat.com
Subject: Re: [PATCH] s2io: resolve statistics issues
Date: Fri, 02 Jul 2010 22:30:05 -0700 (PDT) [thread overview]
Message-ID: <20100702.223005.246533917.davem@davemloft.net> (raw)
In-Reply-To: <20100702191349.GD22020@exar.com>
From: Jon Mason <jon.mason@exar.com>
Date: Fri, 2 Jul 2010 14:13:49 -0500
> This patch resolves a number of issues in the statistics gathering of
> the s2io driver.
>
> On Xframe adapters, the received multicast statistics counter includes
> pause frames which are not indicated to the driver. This can cause
> issues where the multicast packet count is higher than what has actually
> been received, possibly higher than the number of packets received.
>
> The driver software counters are replaced with the adapter hardware
> statistics for rx_packets, rx_bytes, and tx_bytes. It also uses the
> overflow registers to determine if the statistics wrapped the 32bit
> register (removing the window of having a statistic value less than the
> previous call). rx_length_errors statistic now includes undersized
> packets in addition to oversized packets in its counting. Finally,
> rx_crc_errors are now being counted.
>
> Signed-off-by: Jon Mason <jon.mason@exar.com>
Looks good, applied.
prev parent reply other threads:[~2010-07-03 5:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-24 23:32 [PATCH] s2io: read rx_packets count from the hardware stats Michal Schmidt
2010-06-29 6:52 ` David Miller
2010-06-30 0:54 ` Jon Mason
2010-07-02 19:13 ` [PATCH] s2io: resolve statistics issues Jon Mason
2010-07-03 5:30 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100702.223005.246533917.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Ramkrishna.Vepa@exar.com \
--cc=Sivakumar.Subramani@exar.com \
--cc=Sreenivasa.Honnur@exar.com \
--cc=jon.mason@exar.com \
--cc=mschmidt@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).