From: David Miller <davem@davemloft.net>
To: richardcochran@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 1/4] net: add driver hooks for time stamping.
Date: Mon, 05 Jul 2010 19:39:43 -0700 (PDT) [thread overview]
Message-ID: <20100705.193943.91330507.davem@davemloft.net> (raw)
In-Reply-To: <20100705.190301.48512969.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Mon, 05 Jul 2010 19:03:01 -0700 (PDT)
> From: Richard Cochran <richardcochran@gmail.com>
> Date: Mon, 5 Jul 2010 07:31:07 +0200
>
>> This patch adds hooks for transmit and receive time stamps. The
>> transmit hook allows a software fallback for transmit time stamps,
>> for MACs lacking time stamping hardware. The receive hook does not yet
>> have any effect, but it prepares the way for hardware time stamping
>> in PHY devices. Using the hooks will still require adding two inline
>> function calls to each MAC driver.
>>
>> Signed-off-by: Richard Cochran <richard.cochran@omicron.at>
>
> Applied.
Actually, this breaks the build.
There are drivers that never saw phylib.h included in them,
which use internal static functions named "phy_read()" and such
which match global interfaces defined in phylib.h
drivers/net/tulip/dmfe.c:334:12: error: conflicting types for 'phy_read'
include/linux/phy.h:437:19: note: previous definition of 'phy_read' was here
drivers/net/tulip/dmfe.c:335:13: error: conflicting types for 'phy_write'
include/linux/phy.h:452:19: note: previous definition of 'phy_write' was here
You're going to need to resolve this issue first, then make sure at a
minimum that an "allmodconfig" build fully passes with an
unconditional include of phylib.h in skbuff.h
I've reverted all of your patches.
next prev parent reply other threads:[~2010-07-06 2:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-05 5:30 [PATCH v2 0/4] Extend Time Stamping Richard Cochran
2010-07-05 5:31 ` [PATCH 1/4] net: add driver hooks for time stamping Richard Cochran
2010-07-06 2:03 ` David Miller
2010-07-06 2:39 ` David Miller [this message]
2010-07-05 5:32 ` [PATCH 2/4] phylib: add a way to make PHY time stamps possible Richard Cochran
2010-07-06 2:03 ` David Miller
2010-07-05 5:33 ` [PATCH 3/4] phylib: preserve ifreq parameter when calling generic phy_mii_ioctl() Richard Cochran
2010-07-06 2:03 ` David Miller
2010-07-05 5:33 ` [PATCH 4/4] phylib: Allow reading and writing a mii bus from atomic context Richard Cochran
2010-07-06 2:05 ` David Miller
2010-07-06 17:09 ` Andy Fleming
2010-07-07 7:18 ` Richard Cochran
2010-07-16 11:25 ` Richard Cochran
2010-07-16 11:49 ` Richard Cochran
-- strict thread matches above, loose matches on Subject: below --
2010-06-28 15:33 [PATCH 0/4] Extend Time Stamping Richard Cochran
2010-06-28 15:34 ` [PATCH 1/4] net: add driver hooks for time stamping Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100705.193943.91330507.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).