netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] vxge: show startup message with KERN_INFO
@ 2010-07-06 13:02 Wu Fengguang
  2010-07-06 16:08 ` Jon Mason
  0 siblings, 1 reply; 3+ messages in thread
From: Wu Fengguang @ 2010-07-06 13:02 UTC (permalink / raw)
  To: David Miller; +Cc: Sreenivasa Honnur, netdev

The original KERN_CRIT will mess up terminals.

CC: Sreenivasa Honnur <Sreenivasa.Honnur@neterion.com>
Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
---
 drivers/net/vxge/vxge-main.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/vxge/vxge-main.c b/drivers/net/vxge/vxge-main.c
index 45c5dc2..93a9147 100644
--- a/drivers/net/vxge/vxge-main.c
+++ b/drivers/net/vxge/vxge-main.c
@@ -4515,9 +4515,9 @@ vxge_starter(void)
 	char version[32];
 	snprintf(version, 32, "%s", DRV_VERSION);
 
-	printk(KERN_CRIT "%s: Copyright(c) 2002-2009 Neterion Inc\n",
+	printk(KERN_INFO "%s: Copyright(c) 2002-2009 Neterion Inc\n",
 		VXGE_DRIVER_NAME);
-	printk(KERN_CRIT "%s: Driver version: %s\n",
+	printk(KERN_INFO "%s: Driver version: %s\n",
 			VXGE_DRIVER_NAME, version);
 
 	verify_bandwidth();
-- 
1.6.6


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] vxge: show startup message with KERN_INFO
  2010-07-06 13:02 [PATCH] vxge: show startup message with KERN_INFO Wu Fengguang
@ 2010-07-06 16:08 ` Jon Mason
  2010-07-07 21:52   ` David Miller
  0 siblings, 1 reply; 3+ messages in thread
From: Jon Mason @ 2010-07-06 16:08 UTC (permalink / raw)
  To: Wu Fengguang; +Cc: David Miller, Sreenivasa Honnur, netdev@vger.kernel.org

On Tue, Jul 06, 2010 at 06:02:03AM -0700, Wu Fengguang wrote:
> The original KERN_CRIT will mess up terminals.

Looks reasonable to me.

Thanks,
Jon

>
> CC: Sreenivasa Honnur <Sreenivasa.Honnur@neterion.com>
> Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
> ---
>  drivers/net/vxge/vxge-main.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/vxge/vxge-main.c b/drivers/net/vxge/vxge-main.c
> index 45c5dc2..93a9147 100644
> --- a/drivers/net/vxge/vxge-main.c
> +++ b/drivers/net/vxge/vxge-main.c
> @@ -4515,9 +4515,9 @@ vxge_starter(void)
>       char version[32];
>       snprintf(version, 32, "%s", DRV_VERSION);
>
> -     printk(KERN_CRIT "%s: Copyright(c) 2002-2009 Neterion Inc\n",
> +     printk(KERN_INFO "%s: Copyright(c) 2002-2009 Neterion Inc\n",
>               VXGE_DRIVER_NAME);
> -     printk(KERN_CRIT "%s: Driver version: %s\n",
> +     printk(KERN_INFO "%s: Driver version: %s\n",
>                       VXGE_DRIVER_NAME, version);
>
>       verify_bandwidth();
> --
> 1.6.6
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

The information and any attached documents contained in this message
may be confidential and/or legally privileged.  The message is
intended solely for the addressee(s).  If you are not the intended
recipient, you are hereby notified that any use, dissemination, or
reproduction is strictly prohibited and may be unlawful.  If you are
not the intended recipient, please contact the sender immediately by
return e-mail and destroy all copies of the original message.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] vxge: show startup message with KERN_INFO
  2010-07-06 16:08 ` Jon Mason
@ 2010-07-07 21:52   ` David Miller
  0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2010-07-07 21:52 UTC (permalink / raw)
  To: jon.mason; +Cc: fengguang.wu, Sreenivasa.Honnur, netdev

From: Jon Mason <jon.mason@exar.com>
Date: Tue, 6 Jul 2010 11:08:25 -0500

> On Tue, Jul 06, 2010 at 06:02:03AM -0700, Wu Fengguang wrote:
>> The original KERN_CRIT will mess up terminals.
> 
> Looks reasonable to me.
...
>> CC: Sreenivasa Honnur <Sreenivasa.Honnur@neterion.com>
>> Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-07-07 21:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-06 13:02 [PATCH] vxge: show startup message with KERN_INFO Wu Fengguang
2010-07-06 16:08 ` Jon Mason
2010-07-07 21:52   ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).