From: chas williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
To: Karl Hiramoto <karl@hiramoto.org>
Cc: linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org,
nathan@traverse.com.au
Subject: Re: [PATCH v2 1/9] atm: propagate signal changes via notifier
Date: Tue, 6 Jul 2010 15:29:50 -0400 [thread overview]
Message-ID: <20100706152950.1ace642d@thirdoffive.cmf.nrl.navy.mil> (raw)
In-Reply-To: <1278319561-23548-2-git-send-email-karl@hiramoto.org>
On Mon, 5 Jul 2010 10:45:53 +0200
Karl Hiramoto <karl@hiramoto.org> wrote:
> +void atm_dev_signal_change(struct atm_dev *dev, char signal)
> +{
> + int i;
> + pr_debug("%s signal=%d dev=%p number=%d dev->signal=%d\n",
> + __func__, signal, dev, dev->number, dev->signal);
> +
> + /* atm driver sending invalid signal */
> + WARN_ON(signal < ATM_PHY_SIG_LOST || signal >
> ATM_PHY_SIG_FOUND); +
> + if (dev->signal == signal)
> + return; /* no change */
> +
> + dev->signal = signal;
> +
> + blocking_notifier_call_chain(&atm_dev_notify_chain, signal,
> dev); +}
> +EXPORT_SYMBOL(atm_dev_signal_change);
net/atm/common.c: In function 'atm_dev_signal_change':
net/atm/common.c:213: warning: unused variable 'i'
please remove i unless you need it
next prev parent reply other threads:[~2010-07-06 19:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-05 8:45 [PATCH v2 0/9] atm: propagate atm_dev signal carrier to LOWER_UP of netdevice Karl Hiramoto
2010-07-05 8:45 ` [PATCH v2 1/9] atm: propagate signal changes via notifier Karl Hiramoto
2010-07-06 19:29 ` chas williams - CONTRACTOR [this message]
2010-07-06 19:33 ` chas williams - CONTRACTOR
2010-07-06 19:41 ` chas williams - CONTRACTOR
2010-07-07 7:40 ` Karl Hiramoto
2010-07-05 8:45 ` [PATCH v2 2/9] atm/br2684: register notifier event for carrier signal changes Karl Hiramoto
2010-07-05 8:45 ` [PATCH v2 3/9] atm/adummy: add syfs DEVICE_ATTR to change signal Karl Hiramoto
2010-07-05 8:45 ` [PATCH v2 4/9] atm/idt77105.c: call atm_dev_signal_change() when signal changes Karl Hiramoto
2010-07-05 8:45 ` [PATCH v2 5/9] atm/solos-pci: " Karl Hiramoto
2010-07-05 8:45 ` [PATCH v2 6/9] atm/suni.c: " Karl Hiramoto
2010-07-05 8:45 ` [PATCH v2 7/9] usb/atm/cxacru.c: " Karl Hiramoto
2010-07-05 8:46 ` [PATCH v2 8/9] usb/atm/speedtch.c: " Karl Hiramoto
2010-07-05 8:46 ` [PATCH v2 9/9] usb/atm/ueagle-atm.c: " Karl Hiramoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100706152950.1ace642d@thirdoffive.cmf.nrl.navy.mil \
--to=chas@cmf.nrl.navy.mil \
--cc=karl@hiramoto.org \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=nathan@traverse.com.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).