From: Jon Mason <jon.mason@exar.com>
To: Wu Fengguang <fengguang.wu@intel.com>
Cc: David Miller <davem@davemloft.net>,
Sreenivasa Honnur <Sreenivasa.Honnur@neterion.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH] vxge: show startup message with KERN_INFO
Date: Tue, 6 Jul 2010 11:08:25 -0500 [thread overview]
Message-ID: <20100706160824.GA31635@exar.com> (raw)
In-Reply-To: <20100706130203.GA31471@localhost>
On Tue, Jul 06, 2010 at 06:02:03AM -0700, Wu Fengguang wrote:
> The original KERN_CRIT will mess up terminals.
Looks reasonable to me.
Thanks,
Jon
>
> CC: Sreenivasa Honnur <Sreenivasa.Honnur@neterion.com>
> Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
> ---
> drivers/net/vxge/vxge-main.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/vxge/vxge-main.c b/drivers/net/vxge/vxge-main.c
> index 45c5dc2..93a9147 100644
> --- a/drivers/net/vxge/vxge-main.c
> +++ b/drivers/net/vxge/vxge-main.c
> @@ -4515,9 +4515,9 @@ vxge_starter(void)
> char version[32];
> snprintf(version, 32, "%s", DRV_VERSION);
>
> - printk(KERN_CRIT "%s: Copyright(c) 2002-2009 Neterion Inc\n",
> + printk(KERN_INFO "%s: Copyright(c) 2002-2009 Neterion Inc\n",
> VXGE_DRIVER_NAME);
> - printk(KERN_CRIT "%s: Driver version: %s\n",
> + printk(KERN_INFO "%s: Driver version: %s\n",
> VXGE_DRIVER_NAME, version);
>
> verify_bandwidth();
> --
> 1.6.6
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
The information and any attached documents contained in this message
may be confidential and/or legally privileged. The message is
intended solely for the addressee(s). If you are not the intended
recipient, you are hereby notified that any use, dissemination, or
reproduction is strictly prohibited and may be unlawful. If you are
not the intended recipient, please contact the sender immediately by
return e-mail and destroy all copies of the original message.
next prev parent reply other threads:[~2010-07-06 16:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-06 13:02 [PATCH] vxge: show startup message with KERN_INFO Wu Fengguang
2010-07-06 16:08 ` Jon Mason [this message]
2010-07-07 21:52 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100706160824.GA31635@exar.com \
--to=jon.mason@exar.com \
--cc=Sreenivasa.Honnur@neterion.com \
--cc=davem@davemloft.net \
--cc=fengguang.wu@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).