From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: bhutchings@solarflare.com, shemminger@vyatta.com, arnd@arndb.de,
netdev@vger.kernel.org, linux-net-drivers@solarflare.com
Subject: Re: [PATCHv3 2/2] sfc: Implement 64-bit net device statistics on all architectures
Date: Wed, 07 Jul 2010 12:56:57 -0700 (PDT) [thread overview]
Message-ID: <20100707.125657.90809263.davem@davemloft.net> (raw)
In-Reply-To: <1278354682.2877.639.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 05 Jul 2010 20:31:22 +0200
> One other way would be to add a rtnl_link_stats64 param to
> ndo_get_stats64() method, and ask drivers to copy their stats in this
> zone, instead of returning &dev->stats64 or something...
>
> And also change dev_get_stats() with this new parameter.
>
> Each caller would use a private copy, with no risk of concurrent
> updates.
If this can be reliably be made at all call sites, I think such
an approach is preferable.
next prev parent reply other threads:[~2010-07-07 19:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-08 17:19 [PATCHv3 1/2] net: Enable 64-bit net device statistics on 32-bit architectures Ben Hutchings
2010-06-08 17:21 ` [PATCHv3 2/2] sfc: Implement 64-bit net device statistics on all architectures Ben Hutchings
2010-06-12 22:55 ` David Miller
2010-07-05 18:16 ` Eric Dumazet
2010-07-05 18:31 ` Eric Dumazet
2010-07-05 20:05 ` [PATCH net-next-2.6 V2] net: fix 64 bit counters on 32 bit arches Eric Dumazet
2010-07-07 21:36 ` David Miller
2010-07-07 22:41 ` David Miller
2010-07-08 5:18 ` Eric Dumazet
2010-07-07 19:56 ` David Miller [this message]
2010-06-12 22:54 ` [PATCHv3 1/2] net: Enable 64-bit net device statistics on 32-bit architectures David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100707.125657.90809263.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arnd@arndb.de \
--cc=bhutchings@solarflare.com \
--cc=eric.dumazet@gmail.com \
--cc=linux-net-drivers@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).