netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: gjin@ubicom.com, shemminger@vyatta.com, skavy@ubicom.com,
	linux-kernel@vger.kernel.org, gren@ubicom.com,
	msezgin@ubicom.com, silgen@ubicom.com, netdev@vger.kernel.org
Subject: Re: Possible bug in net/ipv4/route.c?
Date: Wed, 07 Jul 2010 14:46:11 -0700 (PDT)	[thread overview]
Message-ID: <20100707.144611.63043873.davem@davemloft.net> (raw)
In-Reply-To: <20100706072928.GB14612@gondor.apana.org.au>

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Tue, 6 Jul 2010 15:29:28 +0800

> bridge: Clear IPCB before possible entry into IP stack
> 
> The bridge protocol lives dangerously by having incestuous relations
> with the IP stack.  In this instance an abomination has been created
> where a bogus IPCB area from a bridged packet leads to a crash in
> the IP stack because it's interpreted as IP options.
> 
> This patch papers over the problem by clearing the IPCB area in that
> particular spot.  To fix this properly we'd also need to parse any
> IP options if present but I'm way too lazy for that.
> 
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Applied, thanks a lot!

      reply	other threads:[~2010-07-07 21:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CB2DD11991B27C4F99935E6229450D3205B28E91@STORK.scenix.com>
2010-07-05 12:04 ` Possible bug in net/ipv4/route.c? Herbert Xu
2010-07-05 16:37   ` Sol Kavy
2010-07-05 18:03   ` Stephen Hemminger
2010-07-06  0:28     ` Herbert Xu
     [not found]       ` <CB2DD11991B27C4F99935E6229450D3203950BE5@STORK.scenix.com>
2010-07-06  7:29         ` Herbert Xu
2010-07-07 21:46           ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100707.144611.63043873.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=gjin@ubicom.com \
    --cc=gren@ubicom.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=msezgin@ubicom.com \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@vyatta.com \
    --cc=silgen@ubicom.com \
    --cc=skavy@ubicom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).