netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: fujita.tomonori@lab.ntt.co.jp
Cc: leedom@chelsio.com, netdev@vger.kernel.org
Subject: Re: [PATCH] cxgb4vf: remove obsolete DECLARE_PCI_UNMAP_ADDR usage
Date: Thu, 08 Jul 2010 23:09:39 -0700 (PDT)	[thread overview]
Message-ID: <20100708.230939.102558536.davem@davemloft.net> (raw)
In-Reply-To: <20100708190126X.fujita.tomonori@lab.ntt.co.jp>

From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Date: Thu, 08 Jul 2010 19:01:26 +0900

> On Thu, 8 Jul 2010 18:52:37 +0900
> FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp> wrote:
> 
>> We could use DEFINE_DMA_UNMAP_ADDR instead but using
>> CONFIG_NEED_DMA_MAP_STATE is a simpler way to see if a platform does
>> real DMA unmapping.
>> 
>> Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
>> ---
>>  drivers/net/cxgb4vf/sge.c |   14 +++++---------
>>  1 files changed, 5 insertions(+), 9 deletions(-)
> 
> btw, I'm not sure that seeing if a platform does real DMA unmapping in
> a driver is a good thing. But I suppose that we need to accept it if
> this leads to big performance boost.
> 
> Both can be applied to net-next.

I think the value of these "optimizations" is rapidly decreasing to
zero.  And I believe I've told the authors of either this driver or
another one that they should just remove this stuff completely.

  reply	other threads:[~2010-07-09  6:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-08  9:52 [PATCH] cxgb4vf: remove obsolete DECLARE_PCI_UNMAP_ADDR usage FUJITA Tomonori
2010-07-08 10:01 ` FUJITA Tomonori
2010-07-09  6:09   ` David Miller [this message]
2010-07-09  6:12     ` FUJITA Tomonori
2010-07-09  6:08 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100708.230939.102558536.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=fujita.tomonori@lab.ntt.co.jp \
    --cc=leedom@chelsio.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).