From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: bhutchings@solarflare.com, netdev@vger.kernel.org, kaber@trash.net
Subject: Re: [PATCH v2] vlan: allow TSO setting on vlan interfaces
Date: Thu, 08 Jul 2010 23:10:14 -0700 (PDT) [thread overview]
Message-ID: <20100708.231014.179943866.davem@davemloft.net> (raw)
In-Reply-To: <1278581971.2651.10.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 08 Jul 2010 11:39:31 +0200
> When we need to shape traffic with low speeds, we need to disable tso on
> network interface :
>
> ethtool -K eth0.2240 tso off
>
> It seems vlan interfaces miss the set_tso() ethtool method.
> Propagating tso changes from lower device is not always wanted, some
> vlans want TSO on, others want TSO off.
>
> Before enabling TSO, we must check real device supports it.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied to net-next-2.6, thanks Eric.
prev parent reply other threads:[~2010-07-09 6:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-07 17:14 [PATCH] vlan: allow TSO setting on vlan interfaces Eric Dumazet
2010-07-07 17:25 ` Ben Hutchings
2010-07-08 6:46 ` Eric Dumazet
2010-07-08 9:39 ` [PATCH v2] " Eric Dumazet
2010-07-08 15:43 ` Ben Hutchings
2010-07-08 15:49 ` Ben Hutchings
2010-07-08 15:55 ` Patrick McHardy
2010-07-08 16:04 ` Eric Dumazet
2010-07-08 16:00 ` Eric Dumazet
2010-07-08 16:05 ` Ben Hutchings
2010-07-08 16:12 ` Eric Dumazet
2010-07-08 16:03 ` Eric Dumazet
2010-07-08 16:37 ` [PATCH v3] " Eric Dumazet
2010-07-08 18:25 ` Ben Hutchings
2010-07-09 6:10 ` David Miller
2010-07-09 6:10 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100708.231014.179943866.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=eric.dumazet@gmail.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).