* [PATCH v3 2/2] ks8842: Remove unnecessary bank select.
@ 2010-07-09 6:28 Richard Röjfors
2010-07-09 6:37 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Richard Röjfors @ 2010-07-09 6:28 UTC (permalink / raw)
To: netdev; +Cc: davem
This patch removes an unnecessary bank select before resetting the
controller.
Signed-off-by: Richard Röjfors <richard.rojfors@pelagicore.com>
---
diff --git a/drivers/net/ks8842.c b/drivers/net/ks8842.c
index 5191af2..0be9261 100644
--- a/drivers/net/ks8842.c
+++ b/drivers/net/ks8842.c
@@ -199,7 +199,6 @@ static void ks8842_reset(struct ks8842_adapter *adapter)
msleep(10);
iowrite16(0, adapter->hw_addr + REG_GRR);
*/
- iowrite16(32, adapter->hw_addr + REG_SELECT_BANK);
iowrite32(0x1, adapter->hw_addr + REG_TIMB_RST);
msleep(20);
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3 2/2] ks8842: Remove unnecessary bank select.
2010-07-09 6:28 [PATCH v3 2/2] ks8842: Remove unnecessary bank select Richard Röjfors
@ 2010-07-09 6:37 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-07-09 6:37 UTC (permalink / raw)
To: richard.rojfors; +Cc: netdev
From: Richard Röjfors <richard.rojfors@pelagicore.com>
Date: Fri, 09 Jul 2010 08:28:16 +0200
> This patch removes an unnecessary bank select before resetting the
> controller.
>
> Signed-off-by: Richard Röjfors <richard.rojfors@pelagicore.com>
Also applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-07-09 6:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-09 6:28 [PATCH v3 2/2] ks8842: Remove unnecessary bank select Richard Röjfors
2010-07-09 6:37 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).