* [PATCH 1/4] ax88796: free irq on error
@ 2010-07-08 12:09 Kulikov Vasiliy
2010-07-09 6:42 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Kulikov Vasiliy @ 2010-07-08 12:09 UTC (permalink / raw)
To: Kernel Janitors
Cc: Paul Gortmaker, David S. Miller, Julia Lawall, Tejun Heo,
Joe Perches, netdev
If ax_ei_open() failed we must free previously requested irq.
Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
---
drivers/net/ax88796.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ax88796.c b/drivers/net/ax88796.c
index 55c9958..20e946b 100644
--- a/drivers/net/ax88796.c
+++ b/drivers/net/ax88796.c
@@ -481,8 +481,10 @@ static int ax_open(struct net_device *dev)
return ret;
ret = ax_ei_open(dev);
- if (ret)
+ if (ret) {
+ free_irq(dev->irq, dev);
return ret;
+ }
/* turn the phy on (if turned off) */
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/4] ax88796: free irq on error
2010-07-08 12:09 [PATCH 1/4] ax88796: free irq on error Kulikov Vasiliy
@ 2010-07-09 6:42 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-07-09 6:42 UTC (permalink / raw)
To: segooon; +Cc: kernel-janitors, p_gortmaker, julia, tj, joe, netdev
From: Kulikov Vasiliy <segooon@gmail.com>
Date: Thu, 8 Jul 2010 16:09:54 +0400
> If ax_ei_open() failed we must free previously requested irq.
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-07-09 6:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-08 12:09 [PATCH 1/4] ax88796: free irq on error Kulikov Vasiliy
2010-07-09 6:42 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).