* Re: [PATCH] lvs sctp protocol handler is incorrectly invoked ip_vs_app_pkt_out [not found] <AANLkTikS9SSVT5soWZYmzxeJkR5vO__cuedk7ZgmTx5y@mail.gmail.com> @ 2010-07-08 12:13 ` Simon Horman 2010-07-09 15:29 ` Patrick McHardy 0 siblings, 1 reply; 2+ messages in thread From: Simon Horman @ 2010-07-08 12:13 UTC (permalink / raw) To: xiaoyu Du; +Cc: linux-kernel, lvs-devel, wensong, NetDev, Patrick McHardy On Thu, Jul 08, 2010 at 09:55:04AM +0800, xiaoyu Du wrote: > lvs sctp protocol handler is incorrectly invoked ip_vs_app_pkt_out > Since there's no sctp helpers at present, it does the same thing as > ip_vs_app_pkt_in. > > Signed-off-by: Xiaoyu Du <tingsrain@gmail.com> Thanks Xiaoyu. Acked-by: Simon Horman <horms@verge.net.au> Patrick, please consider applying this. nf-next should be sufficient, as according to Xiaoyu there aren't actually helpers that exercise this code at the moment. > --- > net/netfilter/ipvs/ip_vs_proto_sctp.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/net/netfilter/ipvs/ip_vs_proto_sctp.c > b/net/netfilter/ipvs/ip_vs_proto_sctp.c > index c9a3f7a..db55759 100644 > --- a/net/netfilter/ipvs/ip_vs_proto_sctp.c > +++ b/net/netfilter/ipvs/ip_vs_proto_sctp.c > @@ -173,7 +173,7 @@ sctp_dnat_handler(struct sk_buff *skb, > return 0; > > /* Call application helper if needed */ > - if (!ip_vs_app_pkt_out(cp, skb)) > + if (!ip_vs_app_pkt_in(cp, skb)) > return 0; > } > > -- ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] lvs sctp protocol handler is incorrectly invoked ip_vs_app_pkt_out 2010-07-08 12:13 ` [PATCH] lvs sctp protocol handler is incorrectly invoked ip_vs_app_pkt_out Simon Horman @ 2010-07-09 15:29 ` Patrick McHardy 0 siblings, 0 replies; 2+ messages in thread From: Patrick McHardy @ 2010-07-09 15:29 UTC (permalink / raw) To: Simon Horman; +Cc: xiaoyu Du, linux-kernel, lvs-devel, wensong, NetDev Am 08.07.2010 14:13, schrieb Simon Horman: > On Thu, Jul 08, 2010 at 09:55:04AM +0800, xiaoyu Du wrote: >> lvs sctp protocol handler is incorrectly invoked ip_vs_app_pkt_out >> Since there's no sctp helpers at present, it does the same thing as >> ip_vs_app_pkt_in. >> >> Signed-off-by: Xiaoyu Du <tingsrain@gmail.com> > > Thanks Xiaoyu. > > Acked-by: Simon Horman <horms@verge.net.au> > > Patrick, please consider applying this. > nf-next should be sufficient, as according > to Xiaoyu there aren't actually helpers > that exercise this code at the moment. Applied, thanks. ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-07-09 15:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <AANLkTikS9SSVT5soWZYmzxeJkR5vO__cuedk7ZgmTx5y@mail.gmail.com>
2010-07-08 12:13 ` [PATCH] lvs sctp protocol handler is incorrectly invoked ip_vs_app_pkt_out Simon Horman
2010-07-09 15:29 ` Patrick McHardy
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).