From: David Miller <davem@davemloft.net>
To: rpartearroyo@albentia.com
Cc: eric.dumazet@gmail.com, herbert@gondor.apana.org.au,
linux-kernel@vger.kernel.org, ipichel@albentia.com,
nmoron@albentia.com, netdev@vger.kernel.org
Subject: Re: [PATCH 001/001] QoS and/or fair queueing: Stateless NAT BUG
Date: Fri, 09 Jul 2010 10:52:53 -0700 (PDT) [thread overview]
Message-ID: <20100709.105253.71108558.davem@davemloft.net> (raw)
In-Reply-To: <201007091937.17349.rpartearroyo@albentia.com>
From: Rodrigo Partearroyo González <rpartearroyo@albentia.com>
Date: Fri, 9 Jul 2010 19:37:16 +0200
> Hi all,
> I have been testing Stateless NAT and found that ICMP packets with length
> less than 20 bytes were not correctly NAT'ed. I have found a BUG that
> makes taking into account IP header length twice, so ICMP packets smaller
> than 20 bytes were being dropped.
>
> Proposed formal patch is below, as suggested by Eric Dumazet, thanks.
> It is taken from 2.6.34.1 stable version.
>
> Signed-off-by: Rodrigo Partearroyo González <rpartearroyo@albentia.com>
Applied, thanks.
next prev parent reply other threads:[~2010-07-09 17:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-09 17:37 [PATCH 001/001] QoS and/or fair queueing: Stateless NAT BUG Rodrigo Partearroyo González
2010-07-09 17:52 ` David Miller [this message]
2010-07-09 17:54 ` Eric Dumazet
-- strict thread matches above, loose matches on Subject: below --
2010-07-09 16:35 rpartearroyo
2010-07-09 17:19 ` Rodrigo Partearroyo González
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100709.105253.71108558.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=ipichel@albentia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nmoron@albentia.com \
--cc=rpartearroyo@albentia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox