From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: felipewd@gmail.com, kaber@trash.net,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] tproxy: nf_tproxy_assign_sock() can handle tw sockets
Date: Fri, 09 Jul 2010 10:53:30 -0700 (PDT) [thread overview]
Message-ID: <20100709.105330.104045737.davem@davemloft.net> (raw)
In-Reply-To: <1278695580.2696.55.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 09 Jul 2010 19:13:00 +0200
> Reviewing tproxy stuff I spotted a problem in nf_tproxy_assign_sock()
> but I could not see how it could explain your crash.
>
> We can read uninitialized memory and trigger a fault in
> nf_tproxy_assign_sock(), not later in tcp_recvmsg()...
>
> David, Patrick, what do you think ?
>
> Thanks
>
> [PATCH] tproxy: nf_tproxy_assign_sock() can handle tw sockets
>
> transparent field of a socket is either inet_twsk(sk)->tw_transparent
> for timewait sockets, or inet_sk(sk)->transparent for other sockets
> (TCP/UDP).
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Looks fine to me:
Acked-by: David S. Miller <davem@davemloft.net>
next prev parent reply other threads:[~2010-07-09 17:53 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <AANLkTimn8A0cYZmwNZYitRkBHKKFe4HQ5GU626DLugkk@mail.gmail.com>
2010-07-08 22:06 ` Squid hang up on 2.6.34 Eric Dumazet
[not found] ` <AANLkTil49m6Ul2bauiH4Pwn-6ykrYTFmSO6_SxqQgD_e@mail.gmail.com>
2010-07-08 22:08 ` Eric Dumazet
2010-07-09 15:03 ` Felipe W Damasio
2010-07-09 16:03 ` Felipe W Damasio
2010-07-09 17:13 ` [PATCH] tproxy: nf_tproxy_assign_sock() can handle tw sockets Eric Dumazet
2010-07-09 17:53 ` David Miller [this message]
2010-07-09 18:16 ` Felipe W Damasio
2010-07-10 3:18 ` Felipe W Damasio
2010-07-10 6:17 ` Eric Dumazet
2010-07-10 19:30 ` David Miller
2010-07-11 3:11 ` Felipe W Damasio
2010-07-11 7:11 ` Felipe W Damasio
2010-07-11 7:13 ` Felipe W Damasio
2010-07-11 8:36 ` Eric Dumazet
2010-07-11 5:19 ` Avi Kivity
2010-07-11 8:02 ` Eric Dumazet
2010-07-12 0:52 ` Felipe W Damasio
2010-07-12 18:49 ` Felipe W Damasio
2010-07-13 14:24 ` Felipe W Damasio
2010-07-13 14:40 ` Eric Dumazet
2010-07-13 14:49 ` Felipe W Damasio
2010-07-13 15:49 ` Eric Dumazet
2010-07-13 20:55 ` Felipe W Damasio
2010-07-13 21:06 ` Felipe W Damasio
2010-07-14 3:21 ` Eric Dumazet
2010-07-14 3:27 ` Felipe W Damasio
2010-07-14 3:43 ` Eric Dumazet
2010-07-14 3:51 ` Felipe W Damasio
2010-07-14 6:56 ` Bill Fink
2010-07-16 15:41 ` Felipe W Damasio
2010-07-16 15:52 ` Eric Dumazet
2010-07-14 11:41 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100709.105330.104045737.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=felipewd@gmail.com \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).