From: chas williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
To: David Miller <davem@davemloft.net>
Cc: karl@hiramoto.org, linux-atm-general@lists.sourceforge.net,
netdev@vger.kernel.org
Subject: Re: [PATCH v4 1/9] atm: propagate signal changes via notifier
Date: Fri, 9 Jul 2010 07:16:10 -0400 [thread overview]
Message-ID: <20100709071610.42473d6c@thirdoffive.cmf.nrl.navy.mil> (raw)
In-Reply-To: <20100708.214745.48520104.davem@davemloft.net>
On Thu, 08 Jul 2010 21:47:45 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:
> From: Karl Hiramoto <karl@hiramoto.org>
> Date: Thu, 8 Jul 2010 10:34:47 +0200
>
> /* Like
> * this.
> */
>
> not:
>
> /*
> * Like
> * this.
> */
>
> Honestly, I don't know how I can be more clear about this :-)
this is somewhat contrary to the suggested multi-line format given in
Documentation/CodingStyle:
The preferred style for long (multi-line) comments is:
/*
* This is the preferred style for multi-line
* comments in the Linux kernel source code.
* Please use it consistently.
*
* Description: A column of asterisks on the left side,
* with beginning and ending almost-blank lines.
*/
next prev parent reply other threads:[~2010-07-09 11:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-08 8:34 [PATCH v4 0/9] atm: propagate atm_dev signal carrier to LOWER_UP of netdevice Karl Hiramoto
2010-07-08 8:34 ` [PATCH v4 1/9] atm: propagate signal changes via notifier Karl Hiramoto
2010-07-09 4:47 ` David Miller
2010-07-09 6:36 ` Karl Hiramoto
2010-07-09 6:38 ` David Miller
2010-07-09 6:50 ` Simon Horman
2010-07-09 6:53 ` David Miller
2010-07-09 7:04 ` Simon Horman
2010-07-09 11:16 ` chas williams - CONTRACTOR [this message]
2010-07-09 12:22 ` Simon Horman
2010-07-09 16:48 ` David Miller
2010-07-09 17:44 ` chas williams - CONTRACTOR
2010-07-08 8:34 ` [PATCH v4 2/9] atm/br2684: register notifier event for carrier signal changes Karl Hiramoto
2010-07-08 8:34 ` [PATCH v4 3/9] atm/adummy: add syfs DEVICE_ATTR to change signal Karl Hiramoto
2010-07-08 8:34 ` [PATCH v4 4/9] atm/idt77105.c: call atm_dev_signal_change() when signal changes Karl Hiramoto
2010-07-08 8:34 ` [PATCH v4 5/9] atm/solos-pci: " Karl Hiramoto
2010-07-08 8:34 ` [PATCH v4 6/9] atm/suni.c: " Karl Hiramoto
2010-07-08 8:34 ` [PATCH v4 7/9] usb/atm/cxacru.c: " Karl Hiramoto
2010-07-08 8:34 ` [PATCH v4 8/9] usb/atm/speedtch.c: " Karl Hiramoto
2010-07-08 8:34 ` [PATCH v4 9/9] usb/atm/ueagle-atm.c: " Karl Hiramoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100709071610.42473d6c@thirdoffive.cmf.nrl.navy.mil \
--to=chas@cmf.nrl.navy.mil \
--cc=davem@davemloft.net \
--cc=karl@hiramoto.org \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).