From: David Miller <davem@davemloft.net>
To: tj@kernel.org
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
henning.fehrmann@aei.mpg.de, carsten.aulbert@aei.mpg.de
Subject: Re: oops in tcp_xmit_retransmit_queue() w/ v2.6.32.15
Date: Sat, 10 Jul 2010 19:36:34 -0700 (PDT) [thread overview]
Message-ID: <20100710.193634.229744909.davem@davemloft.net> (raw)
In-Reply-To: <4C358AAA.9080400@kernel.org>
From: Tejun Heo <tj@kernel.org>
Date: Thu, 08 Jul 2010 10:22:02 +0200
> We've been seeing oops in tcp_xmit_retransmit_queue() w/ 2.6.32.15.
...
> Does anything ring a bell?
A long time ago we had a packet scheduler bug that could corrupt
the TCP socket queues, but that was fixed in 2.6.27 so would
definitely be fixed in your kernel.
--------------------
commit 69747650c814a8a79fef412c7416adf823293a3e
Author: David S. Miller <davem@davemloft.net>
Date: Sun Aug 17 23:55:36 2008 -0700
pkt_sched: Fix return value corruption in HTB and TBF.
Based upon a bug report by Josip Rodin.
Packet schedulers should only return NET_XMIT_DROP iff
the packet really was dropped. If the packet does reach
the device after we return NET_XMIT_DROP then TCP can
crash because it depends upon the enqueue path return
values being accurate.
Signed-off-by: David S. Miller <davem@davemloft.net>
--------------------
Nothing else jumps to mind, sorry.
next prev parent reply other threads:[~2010-07-11 2:36 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-08 8:22 oops in tcp_xmit_retransmit_queue() w/ v2.6.32.15 Tejun Heo
2010-07-11 2:36 ` David Miller [this message]
2010-07-11 16:09 ` Ilpo Järvinen
2010-07-11 17:06 ` Eric Dumazet
2010-07-11 17:46 ` Eric Dumazet
2010-07-11 18:29 ` Eric Dumazet
2010-07-11 19:22 ` Ilpo Järvinen
2010-07-11 19:25 ` Ilpo Järvinen
2010-07-11 19:44 ` Ilpo Järvinen
2010-07-15 11:58 ` Lennart Schulte
2010-07-15 12:05 ` Eric Dumazet
2010-07-15 12:55 ` Lennart Schulte
2010-07-16 12:02 ` Ilpo Järvinen
2010-07-16 12:25 ` Lennart Schulte
2010-07-16 13:19 ` Ilpo Järvinen
2010-07-19 8:06 ` Lennart Schulte
2010-07-19 11:16 ` [PATCHv2] tcp: fix crash in tcp_xmit_retransmit_queue Ilpo Järvinen
2010-07-19 14:09 ` Eric Dumazet
2010-07-19 17:25 ` Ilpo Järvinen
2010-07-19 17:39 ` Eric Dumazet
2010-07-19 19:55 ` David Miller
2010-07-20 8:33 ` Ilpo Järvinen
2010-07-19 14:57 ` oops in tcp_xmit_retransmit_queue() w/ v2.6.32.15 Tejun Heo
2010-07-20 8:41 ` Ilpo Järvinen
2010-09-08 9:32 ` Ilpo Järvinen
2010-09-08 10:25 ` Tejun Heo
2010-09-08 10:34 ` Ilpo Järvinen
2010-09-09 10:27 ` Tejun Heo
2010-09-09 10:45 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100710.193634.229744909.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=carsten.aulbert@aei.mpg.de \
--cc=henning.fehrmann@aei.mpg.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).