From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: oops in tcp_xmit_retransmit_queue() w/ v2.6.32.15 Date: Sat, 10 Jul 2010 19:36:34 -0700 (PDT) Message-ID: <20100710.193634.229744909.davem@davemloft.net> References: <4C358AAA.9080400@kernel.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, henning.fehrmann@aei.mpg.de, carsten.aulbert@aei.mpg.de To: tj@kernel.org Return-path: In-Reply-To: <4C358AAA.9080400@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Tejun Heo Date: Thu, 08 Jul 2010 10:22:02 +0200 > We've been seeing oops in tcp_xmit_retransmit_queue() w/ 2.6.32.15. ... > Does anything ring a bell? A long time ago we had a packet scheduler bug that could corrupt the TCP socket queues, but that was fixed in 2.6.27 so would definitely be fixed in your kernel. -------------------- commit 69747650c814a8a79fef412c7416adf823293a3e Author: David S. Miller Date: Sun Aug 17 23:55:36 2008 -0700 pkt_sched: Fix return value corruption in HTB and TBF. Based upon a bug report by Josip Rodin. Packet schedulers should only return NET_XMIT_DROP iff the packet really was dropped. If the packet does reach the device after we return NET_XMIT_DROP then TCP can crash because it depends upon the enqueue path return values being accurate. Signed-off-by: David S. Miller -------------------- Nothing else jumps to mind, sorry.