From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next] drivers/scsi: Remove warnings after vsprintf %pV introduction Date: Sat, 10 Jul 2010 23:10:26 -0700 (PDT) Message-ID: <20100710.231026.233698429.davem@davemloft.net> References: <1278562423.1712.43.camel@Joe-Laptop> <20100710.195210.200371025.davem@davemloft.net> <1278824921.1501.37.camel@Joe-Laptop.home> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: sfr@canb.auug.org.au, netdev@vger.kernel.org, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, gregkh@suse.de, James.Bottomley@suse.de, matthew@wil.cx, linux-scsi@vger.kernel.org To: joe@perches.com Return-path: In-Reply-To: <1278824921.1501.37.camel@Joe-Laptop.home> Sender: linux-next-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Joe Perches Date: Sat, 10 Jul 2010 22:08:41 -0700 > On Sat, 2010-07-10 at 19:52 -0700, David Miller wrote: >> Could you take a stab at this and the other scsi bits that >> trigger this warning? > > Remove warnings introduced by conversions of dev_ > macros to functions. > > Compile tested only. > > Signed-off-by: Joe Perches SCSI folks, the background is that we have moved the dev_*() printk macros to external functions, so that the prefixing printf strings don't get emitting at every call site. As a consequence, dev_*() calls that try to use an empty string as the printf format emit a warning from gcc since an empty constant string is not a valid printf format. That's what this change is all about. Anyways: Acked-by: David S. Miller