From: David Miller <davem@davemloft.net>
To: dm@chelsio.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] cxgb4: exclude registers with read side effects from register dumps
Date: Sun, 11 Jul 2010 17:34:00 -0700 (PDT) [thread overview]
Message-ID: <20100711.173400.13755695.davem@davemloft.net> (raw)
In-Reply-To: <1278894512-6358-1-git-send-email-dm@chelsio.com>
From: Dimitris Michailidis <dm@chelsio.com>
Date: Sun, 11 Jul 2010 17:28:32 -0700
> A few registers have side effects on reads, eg FIFO pointers that
> auto advance or mailboxes which change ownership when read. They are
> unsafe to read so exclude them from ethtool register dumps.
>
> Bump ethtool_regs.version to indicate the changed register set.
>
> Signed-off-by: Dimitris Michailidis <dm@chelsio.com>
Applied, thank you.
prev parent reply other threads:[~2010-07-12 0:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-12 0:28 [PATCH net-next] cxgb4: exclude registers with read side effects from register dumps Dimitris Michailidis
2010-07-12 0:34 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100711.173400.13755695.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dm@chelsio.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).