From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: xiaosuo@gmail.com, hadi@cyberus.ca, rpartearroyo@albentia.com,
herbert@gondor.apana.org.au, ipichel@albentia.com,
nmoron@albentia.com, netdev@vger.kernel.org
Subject: Re: [PATCH] act_nat: not all of the ICMP packets need an IP header payload
Date: Mon, 12 Jul 2010 20:02:12 -0700 (PDT) [thread overview]
Message-ID: <20100712.200212.235693051.davem@davemloft.net> (raw)
In-Reply-To: <1278742953.2538.24.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Sat, 10 Jul 2010 08:22:33 +0200
> Rodrigo spent lot of time to find the problem and is willing to fix it.
I gave Rodrigo suitable credit in the final commit message.
--------------------
From 70c2efa5a32a7d38e66224844032160317fa7887 Mon Sep 17 00:00:00 2001
From: Changli Gao <xiaosuo@gmail.com>
Date: Fri, 9 Jul 2010 15:33:25 +0000
Subject: [PATCH] act_nat: not all of the ICMP packets need an IP header payload
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
not all of the ICMP packets need an IP header payload, so we check the length
of the skbs only when the packets should have an IP header payload.
Based upon analysis and initial patch by Rodrigo Partearroyo González.
Signed-off-by: Changli Gao <xiaosuo@gmail.com>
Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
--------------------
next prev parent reply other threads:[~2010-07-13 3:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-10 1:33 [PATCH] act_nat: not all of the ICMP packets need an IP header payload Changli Gao
2010-07-10 6:22 ` Eric Dumazet
2010-07-10 14:08 ` Changli Gao
2010-07-13 3:02 ` David Miller [this message]
2010-07-10 6:26 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100712.200212.235693051.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=hadi@cyberus.ca \
--cc=herbert@gondor.apana.org.au \
--cc=ipichel@albentia.com \
--cc=netdev@vger.kernel.org \
--cc=nmoron@albentia.com \
--cc=rpartearroyo@albentia.com \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).