From: David Miller <davem@davemloft.net>
To: amit.salecha@qlogic.com
Cc: netdev@vger.kernel.org, ameen.rahman@qlogic.com,
rajesh.borundia@qlogic.com
Subject: Re: [PATCHv2 NEXT 1/5] qlcnic: fix pause params setting
Date: Tue, 13 Jul 2010 23:09:09 -0700 (PDT) [thread overview]
Message-ID: <20100713.230909.104045607.davem@davemloft.net> (raw)
In-Reply-To: <1279086893-22523-2-git-send-email-amit.salecha@qlogic.com>
From: amit.salecha@qlogic.com
Date: Tue, 13 Jul 2010 22:54:49 -0700
> From: Rajesh Borundia <rajesh.borundia@qlogic.com>
>
> Turning off rx pause param and autoneg param is not supported so
> return error in that case.
>
> Signed-off-by: Rajesh Borundia <rajesh.borundia@qlogic.com>
> Signed-off-by: Amit Kumar Salecha <amit.salecha@qlogic.com>
> ---
> drivers/net/qlcnic/qlcnic_ethtool.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/qlcnic/qlcnic_ethtool.c b/drivers/net/qlcnic/qlcnic_ethtool.c
> index baf5a52..8599993 100644
> --- a/drivers/net/qlcnic/qlcnic_ethtool.c
> +++ b/drivers/net/qlcnic/qlcnic_ethtool.c
> @@ -578,8 +578,13 @@ qlcnic_set_pauseparam(struct net_device *netdev,
> }
> QLCWR32(adapter, QLCNIC_NIU_GB_PAUSE_CTL, val);
> } else if (adapter->ahw.port_type == QLCNIC_XGBE) {
> +
> + if (!pause->rx_pause || pause->autoneg)
> + return -EOPNOTSUPP;
There is no reason to add an empty line at the beginning of this
code block, please remove it.
next prev parent reply other threads:[~2010-07-14 6:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-14 5:54 [PATCHv2 NEXT 0/5]qlcnic: aer state amit.salecha
2010-07-14 5:54 ` [PATCHv2 NEXT 1/5] qlcnic: fix pause params setting amit.salecha
2010-07-14 6:09 ` David Miller [this message]
2010-07-14 5:54 ` [PATCHv2 NEXT 2/5] qlcnic: disable tx timeout recovery amit.salecha
2010-07-14 6:09 ` David Miller
2010-07-14 5:54 ` [PATCHv2 NEXT 3/5] qlcnic: fix netdev notifier in error path amit.salecha
2010-07-14 5:54 ` [PATCHv2 NEXT 4/5] qlcnic: aer support amit.salecha
2010-07-14 5:54 ` [PATCHv2 NEXT 5/5] qlcnic: restore NPAR config data after recovery amit.salecha
2010-07-14 6:10 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100713.230909.104045607.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ameen.rahman@qlogic.com \
--cc=amit.salecha@qlogic.com \
--cc=netdev@vger.kernel.org \
--cc=rajesh.borundia@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).