From: David Miller <davem@davemloft.net>
To: prarit@redhat.com
Cc: netdev@vger.kernel.org
Subject: Re: [RFC PATCH]: Fix a warning in the niu driver
Date: Wed, 14 Jul 2010 11:28:00 -0700 (PDT) [thread overview]
Message-ID: <20100714.112800.189702548.davem@davemloft.net> (raw)
In-Reply-To: <4C3DB927.2060106@redhat.com>
From: Prarit Bhargava <prarit@redhat.com>
Date: Wed, 14 Jul 2010 09:18:31 -0400
> Dave, would it be acceptable if I then wrapped link in
> uninitialized_var() to get rid of the warning I'm trying to resolve? It
> seems that your patch then checks for a valid page value so it should be
> okay.
If the patch I posted doesn't fix your warning, the compiler is broken.
Any code path that would not initialize the variable, hits the BUG()
therefore making return from the function completely unreachable,
therefore the uses of the initialized variable are completely unreachable.
I'm not adding workarounds for compiler warning bugs. They aren't real
bugs, and such efforts tend to _add_ bugs to the tree rather than fix
real problems.
next prev parent reply other threads:[~2010-07-14 18:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-07 23:59 [RFC PATCH]: Fix a warning in the niu driver Prarit Bhargava
2010-07-08 0:08 ` David Miller
2010-07-14 13:18 ` Prarit Bhargava
2010-07-14 18:28 ` David Miller [this message]
2010-07-14 18:26 ` Prarit Bhargava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100714.112800.189702548.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=prarit@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).