From: David Miller <davem@davemloft.net>
To: timo.teras@iki.fi
Cc: netdev@vger.kernel.org, linux@horizon.com
Subject: Re: [PATCH] xfrm: do not assume that template resolving always returns xfrms
Date: Wed, 14 Jul 2010 14:17:07 -0700 (PDT) [thread overview]
Message-ID: <20100714.141707.246527574.davem@davemloft.net> (raw)
In-Reply-To: <1279006182-11421-1-git-send-email-timo.teras@iki.fi>
From: Timo Teräs <timo.teras@iki.fi>
Date: Tue, 13 Jul 2010 10:29:42 +0300
> xfrm_resolve_and_create_bundle() assumed that, if policies indicated
> presence of xfrms, bundle template resolution would always return
> some xfrms. This is not true for 'use' level policies which can
> result in no xfrm's being applied if there is no suitable xfrm states.
> This fixes a crash by this incorrect assumption.
>
> Reported-by: George Spelvin <linux@horizon.com>
> Bisected-by: George Spelvin <linux@horizon.com>
> Tested-by: George Spelvin <linux@horizon.com>
> Signed-off-by: Timo Teräs <timo.teras@iki.fi>
Applied, thanks Timo.
prev parent reply other threads:[~2010-07-14 21:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4C39D834.8080206@iki.fi>
2010-07-11 17:09 ` [REGRESSION,BISECTED] Panic on ifup George Spelvin
2010-07-12 7:01 ` Timo Teräs
2010-07-13 1:50 ` George Spelvin
2010-07-13 4:20 ` David Miller
2010-07-13 7:29 ` [PATCH] xfrm: do not assume that template resolving always returns xfrms Timo Teräs
2010-07-14 21:17 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100714.141707.246527574.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux@horizon.com \
--cc=netdev@vger.kernel.org \
--cc=timo.teras@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).