From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: rdkehn@yahoo.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next-2.6] net/core: neighbour update Oops
Date: Wed, 14 Jul 2010 18:02:46 -0700 (PDT) [thread overview]
Message-ID: <20100714.180246.39175076.davem@davemloft.net> (raw)
In-Reply-To: <1279035511.2634.456.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 13 Jul 2010 17:38:31 +0200
> Le mardi 13 juillet 2010 à 08:23 -0700, Doug Kehn a écrit :
>> When configuring DMVPN (GRE + openNHRP) and a GRE remote
>> address is configured a kernel Oops is observed. The
>> obserseved Oops is caused by a NULL header_ops pointer
>> (neigh->dev->header_ops) in neigh_update_hhs() when
>>
>> void (*update)(struct hh_cache*, const struct net_device*, const unsigned char *)
>> = neigh->dev->header_ops->cache_update;
>>
>> is executed. The dev associated with the NULL header_ops is
>> the GRE interface. This patch guards against the
>> possibility that header_ops is NULL.
>>
>> This Oops was first observed in kernel version 2.6.26.8.
>>
>> Signed-off-by: Doug Kehn <rdkehn@yahoo.com>
>
> Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied and queued up for -stable, thanks!
prev parent reply other threads:[~2010-07-15 1:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-13 15:23 [PATCH net-next-2.6] net/core: neighbour update Oops Doug Kehn
2010-07-13 15:38 ` Eric Dumazet
2010-07-15 1:02 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100714.180246.39175076.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rdkehn@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).