From: David Miller <davem@davemloft.net>
To: nicolas.2p.debian@free.fr
Cc: bonding-devel@lists.sourceforge.net, andy@greyhouse.net,
fubar@us.ibm.com, netdev@vger.kernel.org
Subject: Re: [PATCH] bonding: fix a buffer overflow in bonding_show_queue_id.
Date: Wed, 14 Jul 2010 18:25:05 -0700 (PDT) [thread overview]
Message-ID: <20100714.182505.115922952.davem@davemloft.net> (raw)
In-Reply-To: <1279146277-9381-1-git-send-email-nicolas.2p.debian@free.fr>
From: Nicolas de Pesloüan <nicolas.2p.debian@free.fr>
Date: Thu, 15 Jul 2010 00:24:37 +0200
> The test for buffer overflow ensures we have room for 6 more bytes.
> sprintf, called with %s:%d, slave->dev->name, slave->queue_id may yield
> far more than 6 bytes.
>
> The correct test is res > (PAGE_SIZE - IFNAMSIZ - 6) .
>
> Signed-off-by: Nicolas de Pesloüan <nicolas.2p.debian@free.fr>
Applied to net-next-2.6, thanks.
prev parent reply other threads:[~2010-07-15 1:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-14 22:24 [PATCH] bonding: fix a buffer overflow in bonding_show_queue_id Nicolas de Pesloüan
2010-07-15 1:25 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100714.182505.115922952.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andy@greyhouse.net \
--cc=bonding-devel@lists.sourceforge.net \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.2p.debian@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).