From: David Miller <davem@davemloft.net>
To: chihau@gmail.com
Cc: eric.dumazet@gmail.com, opurdila@ixiacom.com,
netdev@vger.kernel.org, linux-devel@vger.kernel.org,
mitov@issp.bas.bg
Subject: Re: [PATCH] Net: ethernet: eth: fix some code style issues
Date: Wed, 14 Jul 2010 18:26:30 -0700 (PDT) [thread overview]
Message-ID: <20100714.182630.48510763.davem@davemloft.net> (raw)
In-Reply-To: <1279138937-12985-1-git-send-email-chihau@gmail.com>
From: Chihau Chau <chihau@gmail.com>
Date: Wed, 14 Jul 2010 16:22:17 -0400
> @@ -180,7 +180,8 @@ __be16 eth_type_trans(struct sk_buff *skb, struct net_device *dev)
> * seems to set IFF_PROMISC.
> */
>
> - else if (1 /*dev->flags&IFF_PROMISC */ ) {
> + /*dev->flags&IFF_PROMISC */
> + else if (1) {
This makes the code look worse, not better.
If the commented test is in the parenthesis, it is unambiguous
which piece of code the suggested test is meant for.
prev parent reply other threads:[~2010-07-15 1:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-14 20:22 [PATCH] Net: ethernet: eth: fix some code style issues Chihau Chau
2010-07-15 1:26 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100714.182630.48510763.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=chihau@gmail.com \
--cc=eric.dumazet@gmail.com \
--cc=linux-devel@vger.kernel.org \
--cc=mitov@issp.bas.bg \
--cc=netdev@vger.kernel.org \
--cc=opurdila@ixiacom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).