From: David Miller <davem@davemloft.net>
To: ramirose@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next-2.6] xfrm: cleanup of xfrm_input.c. (resend)
Date: Wed, 14 Jul 2010 22:42:21 -0700 (PDT) [thread overview]
Message-ID: <20100714.224221.226759932.davem@davemloft.net> (raw)
In-Reply-To: <AANLkTim7fVRtycf2B07iI7U4chv2NqD267dvunZJYqPj@mail.gmail.com>
From: Rami Rosen <ramirose@gmail.com>
Date: Thu, 15 Jul 2010 08:21:03 +0300
> Hi,
> The patch removes unneeded inclusion of header files
> (linux/module.h, linux/netdevice.h, net/dst.h and net/ip.h) and adds inclusion
> of linux/skbuff.h instead, in net/xfrm/xfrm_input.c.
Rami, please don't process my feedback like an automaton. :-/
I specifically mentioned linux/skbuff.h because that happened to be
the very first obvious header dependency I found in the xfrm_input.c
file.
There are almost certainly others, and I'd like for you to take the
time to skim over the file and figure out what those might be.
Also, when submitting a new version of a patch, do not hijack the
existing thread. Instead, make a full fresh submission with a
plain fresh subject line, commit log message, signoff, and patch.
prev parent reply other threads:[~2010-07-15 5:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-15 5:21 [PATCH net-next-2.6] xfrm: cleanup of xfrm_input.c. (resend) Rami Rosen
2010-07-15 5:42 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100714.224221.226759932.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=ramirose@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).