From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: rolandd@cisco.com, yevgenyp@mellanox.co.il,
jackm@dev.mellanox.co.il, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] drivers/net/mlx4: Use %pV, pr_<level>, printk_once
Date: Thu, 15 Jul 2010 19:07:34 -0700 (PDT) [thread overview]
Message-ID: <20100715.190734.245390906.davem@davemloft.net> (raw)
In-Reply-To: <baf5f3949ffd5a48a6f5667b6d6394e6d48c91ca.1278696312.git.joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Sat, 10 Jul 2010 10:22:46 -0700
> Remove near duplication of format string constants by using the newly
> introduced vsprintf extention %pV to reduce text by 20k or so.
>
> $ size drivers/net/mlx4/built-in.o*
> text data bss dec hex filename
> 161367 1866 48784 212017 33c31 drivers/net/mlx4/built-in.o
> 142621 1866 46248 190735 2e90f drivers/net/mlx4/built-in.o.new
>
> Use printk_once as appropriate.
> Convert printks to pr_<level>, some bare printks now use pr_cont.
> Remove now unused #define PFX.
>
> Signed-off-by: Joe Perches <joe@perches.com>
Applied, thanks Joe.
prev parent reply other threads:[~2010-07-16 2:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-10 17:22 [PATCH net-next] drivers/net/mlx4: Use %pV, pr_<level>, printk_once Joe Perches
2010-07-16 2:07 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100715.190734.245390906.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jackm@dev.mellanox.co.il \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rolandd@cisco.com \
--cc=yevgenyp@mellanox.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).