From: David Miller <davem@davemloft.net>
To: mchan@broadcom.com
Cc: sgruszka@redhat.com, netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] bnx2: allocate with GFP_KERNEL flag on RX path init
Date: Thu, 15 Jul 2010 20:25:37 -0700 (PDT) [thread overview]
Message-ID: <20100715.202537.116398412.davem@davemloft.net> (raw)
In-Reply-To: <C27F8246C663564A84BB7AB3439772421B842BD26F@IRVEXCHCCR01.corp.ad.broadcom.com>
From: "Michael Chan" <mchan@broadcom.com>
Date: Thu, 15 Jul 2010 07:48:40 -0700
> Stanislaw Gruszka wrote:
>
>> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
>> ---
>> @@ -2974,7 +2974,7 @@ bnx2_rx_skb(struct bnx2 *bp, struct
>> bnx2_rx_ring_info *rxr, struct sk_buff *skb,
>> int err;
>> u16 prod = ring_idx & 0xffff;
>>
>> - err = bnx2_alloc_rx_skb(bp, rxr, prod);
>> + err = bnx2_alloc_rx_skb(bp, rxr, prod, GFP_KERNEL);
>
> This should be GFP_ATOMIC since it is called from NAPI softirq
> context.
This fatal issue gives me doubts about whether this patch was even
tested at all.
Immediately the kernel memory allocator should have issued a warning
due to this GFP_KERNEL allocation in a non-sleep'able context.
Stanislaw, how did you test this patch?
next prev parent reply other threads:[~2010-07-16 3:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-15 14:25 [PATCH -next 0/2] bnx2: allow sleep during allocation Stanislaw Gruszka
2010-07-15 14:25 ` [PATCH 1/2] bnx2: allocate with GFP_KERNEL flag on RX path init Stanislaw Gruszka
2010-07-15 14:48 ` Michael Chan
2010-07-16 3:25 ` David Miller [this message]
2010-07-16 5:57 ` Mitchell Erblich
2010-07-16 7:13 ` Stanislaw Gruszka
2010-07-16 8:55 ` [PATCH v2 " Stanislaw Gruszka
2010-07-16 21:24 ` Michael Chan
2010-07-18 21:43 ` David Miller
2010-07-15 18:57 ` [PATCH " Mitchell Erblich
2010-07-16 7:30 ` Stanislaw Gruszka
2010-07-15 14:25 ` [PATCH 2/2] bnx2: use device model DMA API Stanislaw Gruszka
2010-07-16 21:29 ` Michael Chan
2010-07-18 21:43 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100715.202537.116398412.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).