From: David Miller <davem@davemloft.net>
To: gregory.v.rose@intel.com
Cc: segooon@gmail.com, kernel-janitors@vger.kernel.org,
jeffrey.t.kirsher@intel.com, eric.dumazet@gmail.com,
joe@perches.com, netdev@vger.kernel.org
Subject: Re: [PATCH 5/8] drivers: ixgbevf: fix unsigned underflow
Date: Thu, 15 Jul 2010 20:28:38 -0700 (PDT) [thread overview]
Message-ID: <20100715.202838.258102741.davem@davemloft.net> (raw)
In-Reply-To: <43F901BD926A4E43B106BF17856F0755EA96143E@orsmsx508.amr.corp.intel.com>
From: "Rose, Gregory V" <gregory.v.rose@intel.com>
Date: Thu, 15 Jul 2010 11:52:54 -0700
>>-----Original Message-----
>>From: Kulikov Vasiliy [mailto:segooon@gmail.com]
>>Sent: Thursday, July 15, 2010 11:46 AM
>>To: kernel-janitors@vger.kernel.org
>>Cc: David S. Miller; Kirsher, Jeffrey T; Rose, Gregory V; Eric Dumazet;
>>Joe Perches; netdev@vger.kernel.org
>>Subject: [PATCH 5/8] drivers: ixgbevf: fix unsigned underflow
>>
>>'count' is unsigned. It is initialized to zero, then it can be increased
>>multiple times, and finally it is used in such a way:
>>
>> >>>> count--;
>> |
>> | /* clear timestamp and dma mappings for remaining portion of
>>packet */
>> | while (count >= 0) {
>> | count--;
>> | ...
>> ^
>>If count is zero here (so, it was never increased), we would have a very
>>long loop :)
>>
>>Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
...
> Acked By: Greg Rose <gregory.v.rose@intel.com>
Applied.
prev parent reply other threads:[~2010-07-16 3:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-15 18:45 [PATCH 5/8] drivers: ixgbevf: fix unsigned underflow Kulikov Vasiliy
2010-07-15 18:52 ` Rose, Gregory V
2010-07-16 3:28 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100715.202838.258102741.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=gregory.v.rose@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=segooon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).