* [PATCH 7/8] net: bridge: fix sign bug
@ 2010-07-15 18:47 Kulikov Vasiliy
2010-07-15 19:21 ` Stephen Hemminger
0 siblings, 1 reply; 3+ messages in thread
From: Kulikov Vasiliy @ 2010-07-15 18:47 UTC (permalink / raw)
To: kernel-janitors
Cc: Stephen Hemminger, David S. Miller, Herbert Xu, YOSHIFUJI Hideaki,
Eric Dumazet, bridge, netdev
ipv6_skip_exthdr() can return error code that is below zero.
'offset' is unsigned, so it makes no sense.
ipv6_skip_exthdr() returns 'int' so we can painlessly change type of
offset to int.
Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
---
net/bridge/br_multicast.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
index 27ae946..85afcda 100644
--- a/net/bridge/br_multicast.c
+++ b/net/bridge/br_multicast.c
@@ -1435,7 +1435,7 @@ static int br_multicast_ipv6_rcv(struct net_bridge *br,
struct icmp6hdr *icmp6h;
u8 nexthdr;
unsigned len;
- unsigned offset;
+ int offset;
int err;
if (!pskb_may_pull(skb, sizeof(*ip6h)))
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 7/8] net: bridge: fix sign bug
2010-07-15 18:47 [PATCH 7/8] net: bridge: fix sign bug Kulikov Vasiliy
@ 2010-07-15 19:21 ` Stephen Hemminger
2010-07-16 3:28 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Hemminger @ 2010-07-15 19:21 UTC (permalink / raw)
To: Kulikov Vasiliy
Cc: kernel-janitors, David S. Miller, Herbert Xu, YOSHIFUJI Hideaki,
Eric Dumazet, bridge, netdev
On Thu, 15 Jul 2010 22:47:33 +0400
Kulikov Vasiliy <segooon@gmail.com> wrote:
> ipv6_skip_exthdr() can return error code that is below zero.
> 'offset' is unsigned, so it makes no sense.
> ipv6_skip_exthdr() returns 'int' so we can painlessly change type of
> offset to int.
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
> ---
> net/bridge/br_multicast.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
> index 27ae946..85afcda 100644
> --- a/net/bridge/br_multicast.c
> +++ b/net/bridge/br_multicast.c
> @@ -1435,7 +1435,7 @@ static int br_multicast_ipv6_rcv(struct net_bridge *br,
> struct icmp6hdr *icmp6h;
> u8 nexthdr;
> unsigned len;
> - unsigned offset;
> + int offset;
> int err;
>
> if (!pskb_may_pull(skb, sizeof(*ip6h)))
Acked-by: Stephen Hemminger <shemminger@vyatta.com>
--
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 7/8] net: bridge: fix sign bug
2010-07-15 19:21 ` Stephen Hemminger
@ 2010-07-16 3:28 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2010-07-16 3:28 UTC (permalink / raw)
To: shemminger
Cc: segooon, kernel-janitors, herbert, yoshfuji, eric.dumazet, bridge,
netdev
From: Stephen Hemminger <shemminger@linux-foundation.org>
Date: Thu, 15 Jul 2010 12:21:44 -0700
> On Thu, 15 Jul 2010 22:47:33 +0400
> Kulikov Vasiliy <segooon@gmail.com> wrote:
>
>> ipv6_skip_exthdr() can return error code that is below zero.
>> 'offset' is unsigned, so it makes no sense.
>> ipv6_skip_exthdr() returns 'int' so we can painlessly change type of
>> offset to int.
>>
>> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
...
> Acked-by: Stephen Hemminger <shemminger@vyatta.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-07-16 3:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-15 18:47 [PATCH 7/8] net: bridge: fix sign bug Kulikov Vasiliy
2010-07-15 19:21 ` Stephen Hemminger
2010-07-16 3:28 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).