From: Stephen Hemminger <shemminger@linux-foundation.org>
To: Kulikov Vasiliy <segooon@gmail.com>
Cc: kernel-janitors@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Herbert Xu <herbert@gondor.hengli.com.au>,
YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>,
Eric Dumazet <eric.dumazet@gmail.com>,
bridge@lists.linux-foundation.org, netdev@vger.kernel.org
Subject: Re: [PATCH 7/8] net: bridge: fix sign bug
Date: Thu, 15 Jul 2010 12:21:44 -0700 [thread overview]
Message-ID: <20100715122144.0f2cf5cf@nehalam> (raw)
In-Reply-To: <1279219653-12791-1-git-send-email-segooon@gmail.com>
On Thu, 15 Jul 2010 22:47:33 +0400
Kulikov Vasiliy <segooon@gmail.com> wrote:
> ipv6_skip_exthdr() can return error code that is below zero.
> 'offset' is unsigned, so it makes no sense.
> ipv6_skip_exthdr() returns 'int' so we can painlessly change type of
> offset to int.
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
> ---
> net/bridge/br_multicast.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
> index 27ae946..85afcda 100644
> --- a/net/bridge/br_multicast.c
> +++ b/net/bridge/br_multicast.c
> @@ -1435,7 +1435,7 @@ static int br_multicast_ipv6_rcv(struct net_bridge *br,
> struct icmp6hdr *icmp6h;
> u8 nexthdr;
> unsigned len;
> - unsigned offset;
> + int offset;
> int err;
>
> if (!pskb_may_pull(skb, sizeof(*ip6h)))
Acked-by: Stephen Hemminger <shemminger@vyatta.com>
--
next prev parent reply other threads:[~2010-07-15 19:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-15 18:47 [PATCH 7/8] net: bridge: fix sign bug Kulikov Vasiliy
2010-07-15 19:21 ` Stephen Hemminger [this message]
2010-07-16 3:28 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100715122144.0f2cf5cf@nehalam \
--to=shemminger@linux-foundation.org \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=herbert@gondor.hengli.com.au \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=segooon@gmail.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).