From: Eldon Koyle <esk-netdev@esk.cs.usu.edu>
To: netdev@vger.kernel.org
Subject: Re: multiqueue, skb_get_queue_mapping() and netdev_get_tx_queue()
Date: Thu, 15 Jul 2010 10:22:02 -0600 [thread overview]
Message-ID: <20100715162201.GB32397@esk.cs.usu.edu> (raw)
In-Reply-To: <20100714231352.GA32397@esk.cs.usu.edu>
On Jul 14 17:13-0600, Eldon Koyle wrote:
> It looks like there is a potential for an out of bounds index anywhere
> skb_get_queue_mapping(skb) (which just returns skb->queue_mapping) is
> used to get an index for netdev_get_tx_queue() (and probably other
> places) on a device with multiple rx/tx queues.
Looking more closely, it looks like skb->queue_mapping is treated
differently between rx and tx. In net/core/dev.c in dev_pick_tx, it
uses skb_tx_hash to get the tx queue it should use and then does:
skb_set_queue_mapping(skb, queue_index);
return netdev_get_tx_queue(dev, queue_index);
Sorry for the noise.
--
Eldon Koyle
--
He who renders warfare fatal to all engaged in it will be the greatest
benefactor the world has yet known.
-- Sir Richard Burton
prev parent reply other threads:[~2010-07-15 16:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-14 23:13 multiqueue, skb_get_queue_mapping() and netdev_get_tx_queue() Eldon Koyle
2010-07-15 16:22 ` Eldon Koyle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100715162201.GB32397@esk.cs.usu.edu \
--to=esk-netdev@esk.cs.usu.edu \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).