netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: penguin-kernel@I-love.SAKURA.ne.jp
Cc: netdev@vger.kernel.org
Subject: Re: [RFC] LSM hook for post recvmsg.
Date: Fri, 16 Jul 2010 12:35:58 -0700 (PDT)	[thread overview]
Message-ID: <20100716.123558.71592004.davem@davemloft.net> (raw)
In-Reply-To: <201007170114.GFC57373.SQJHOVtLFMOFFO@I-love.SAKURA.ne.jp>

From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Date: Sat, 17 Jul 2010 01:14:38 +0900

> Below is a patch for post recvmsg() operation. I modified the patch to call
> skb_recv_datagram() again (for udp_recvmsg(), raw_recvmsg(), udpv6_recvmsg())
> if LSM dicided to drop the message. (Regarding rawv6_recvmsg(), I didn't do so
> in accordance with the comment at "csum_copy_err:".)
> What do you think about this verion?

This looks fine, but regardless of that comment I think the IPV6 raw recvmsg()
should loop just as the IPV4 one does in your patch.

  reply	other threads:[~2010-07-16 19:35 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-16 16:14 [RFC] LSM hook for post recvmsg Tetsuo Handa
2010-07-16 19:35 ` David Miller [this message]
2010-07-17  1:17   ` [PATCH] LSM: Add post recvmsg() hook Tetsuo Handa
2010-07-17 20:34     ` Paul Moore
2010-07-18  8:33     ` Eric Dumazet
2010-07-18 10:49       ` Tetsuo Handa
2010-07-18 21:25         ` David Miller
2010-07-19  4:25           ` [PATCH] LSM: Add post accept() hook Tetsuo Handa
2010-07-19 22:15             ` Paul Moore
2010-07-20  1:36               ` Tetsuo Handa
2010-07-20 19:52                 ` Paul Moore
2010-07-21  2:00                   ` Tetsuo Handa
2010-07-21 16:06                     ` Paul Moore
2010-07-21 18:45     ` [PATCH] LSM: Add post recvmsg() hook David Miller
2010-07-22  3:38       ` Tetsuo Handa
2010-07-22  4:06         ` David Miller
2010-07-22  4:41           ` Tetsuo Handa
2010-07-22  4:45             ` David Miller
2010-07-22  5:02               ` Tetsuo Handa
2010-07-22  5:06                 ` David Miller
2010-07-22 12:46                   ` Tetsuo Handa
2010-07-22 17:22                     ` David Miller
2010-07-22 17:26                       ` David Miller
2010-07-23  0:22                         ` Tetsuo Handa
2010-07-23  5:44                           ` David Miller
2010-07-23  7:21                             ` Tetsuo Handa
2010-07-23  7:29                               ` David Miller
2010-07-23 12:37                       ` Tetsuo Handa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100716.123558.71592004.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=penguin-kernel@I-love.SAKURA.ne.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).