From: Stanislaw Gruszka <sgruszka@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: mchan@broadcom.com, netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] bnx2: allocate with GFP_KERNEL flag on RX path init
Date: Fri, 16 Jul 2010 09:13:34 +0200 [thread overview]
Message-ID: <20100716091334.268a3f0a@dhcp-lab-109.englab.brq.redhat.com> (raw)
In-Reply-To: <20100715.202537.116398412.davem@davemloft.net>
On Thu, 15 Jul 2010 20:25:37 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:
> > This should be GFP_ATOMIC since it is called from NAPI softirq
> > context.
>
> This fatal issue gives me doubts about whether this patch was even
> tested at all.
>
> Immediately the kernel memory allocator should have issued a warning
> due to this GFP_KERNEL allocation in a non-sleep'able context.
>
> Stanislaw, how did you test this patch?
I run net-next-2.6 kernel with patches on machine with bnx2 device,
but I compiled kernel with CONFIG_DEBUG_KOBJECT and all dmesg was filled
by messages like:
kobject: 'block' (ffff8801663122c0): kobject_add_internal: parent: '2:2:1:0', set: '(null)'
kobject: 'sdc' (ffff8801642ca070): kobject_add_internal: parent: 'block', set: 'devices'
kobject: 'sdc' (ffff8801642ca070): kobject_uevent_env
so I missed the warning, grr...
Stanislaw
next prev parent reply other threads:[~2010-07-16 7:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-15 14:25 [PATCH -next 0/2] bnx2: allow sleep during allocation Stanislaw Gruszka
2010-07-15 14:25 ` [PATCH 1/2] bnx2: allocate with GFP_KERNEL flag on RX path init Stanislaw Gruszka
2010-07-15 14:48 ` Michael Chan
2010-07-16 3:25 ` David Miller
2010-07-16 5:57 ` Mitchell Erblich
2010-07-16 7:13 ` Stanislaw Gruszka [this message]
2010-07-16 8:55 ` [PATCH v2 " Stanislaw Gruszka
2010-07-16 21:24 ` Michael Chan
2010-07-18 21:43 ` David Miller
2010-07-15 18:57 ` [PATCH " Mitchell Erblich
2010-07-16 7:30 ` Stanislaw Gruszka
2010-07-15 14:25 ` [PATCH 2/2] bnx2: use device model DMA API Stanislaw Gruszka
2010-07-16 21:29 ` Michael Chan
2010-07-18 21:43 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100716091334.268a3f0a@dhcp-lab-109.englab.brq.redhat.com \
--to=sgruszka@redhat.com \
--cc=davem@davemloft.net \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).