From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Mitchell Erblich <erblichs@earthlink.net>
Cc: netdev@vger.kernel.org, Michael Chan <mchan@broadcom.com>
Subject: Re: [PATCH 1/2] bnx2: allocate with GFP_KERNEL flag on RX path init
Date: Fri, 16 Jul 2010 09:30:19 +0200 [thread overview]
Message-ID: <20100716093019.2a15b0f9@dhcp-lab-109.englab.brq.redhat.com> (raw)
In-Reply-To: <5AD9FE05-1F9B-44DE-8CC4-4D63F43E79C8@earthlink.net>
On Thu, 15 Jul 2010 11:57:59 -0700
Mitchell Erblich <erblichs@earthlink.net> wrote:
> > @@ -3039,7 +3039,8 @@ bnx2_rx_skb(struct bnx2 *bp, struct bnx2_rx_ring_info *rxr, struct sk_buff *skb,
> > rx_pg->page = NULL;
> >
> > err = bnx2_alloc_rx_page(bp, rxr,
> > - RX_PG_RING_IDX(pg_prod));
> > + RX_PG_RING_IDX(pg_prod),
> > +
>
> > GFP_ATOMIC);
>
> Why not GFP_NOWAIT here?
> This would then not use the last reserved pages of memory.
> This still would remove the possibe sleep asociated with GFP_KERNEL.
There is no GFP_NOWAIT usage in any network driver. I'm not sure if
this flag is intended to driver usage. Anyway I can not judge if
GFP_ATOMIC -> GFP_NOWAIT conversion is good or bad idea, I think you
should ask mm guys about that.
Stanislaw
next prev parent reply other threads:[~2010-07-16 7:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-15 14:25 [PATCH -next 0/2] bnx2: allow sleep during allocation Stanislaw Gruszka
2010-07-15 14:25 ` [PATCH 1/2] bnx2: allocate with GFP_KERNEL flag on RX path init Stanislaw Gruszka
2010-07-15 14:48 ` Michael Chan
2010-07-16 3:25 ` David Miller
2010-07-16 5:57 ` Mitchell Erblich
2010-07-16 7:13 ` Stanislaw Gruszka
2010-07-16 8:55 ` [PATCH v2 " Stanislaw Gruszka
2010-07-16 21:24 ` Michael Chan
2010-07-18 21:43 ` David Miller
2010-07-15 18:57 ` [PATCH " Mitchell Erblich
2010-07-16 7:30 ` Stanislaw Gruszka [this message]
2010-07-15 14:25 ` [PATCH 2/2] bnx2: use device model DMA API Stanislaw Gruszka
2010-07-16 21:29 ` Michael Chan
2010-07-18 21:43 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100716093019.2a15b0f9@dhcp-lab-109.englab.brq.redhat.com \
--to=sgruszka@redhat.com \
--cc=erblichs@earthlink.net \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).