From: David Miller <davem@davemloft.net>
To: arno@natisbad.org
Cc: yoshfuji@linux-ipv6.org, netdev@vger.kernel.org
Subject: Re: [PATCH] IPv6: fix CoA check in RH2 input handler (mip6_rthdr_input())
Date: Sun, 18 Jul 2010 15:05:03 -0700 (PDT) [thread overview]
Message-ID: <20100718.150503.267945037.davem@davemloft.net> (raw)
In-Reply-To: <87aapr7lu3.fsf@small.ssi.corp>
From: arno@natisbad.org (Arnaud Ebalard)
Date: Fri, 16 Jul 2010 12:38:44 +0200
> The input handler for Type 2 Routing Header (mip6_rthdr_input())
> checks if the CoA in the packet matches the CoA in the XFRM state.
>
> Current check is buggy: it compares the adddress in the Type 2
> Routing Header, i.e. the HoA, against the expected CoA in the state.
> The comparison should be made against the address in the destination
> field of the IPv6 header.
>
> The bug remained unnoticed because the main (and possibly only current)
> user of the code (UMIP MIPv6 Daemon) initializes the XFRM state with the
> unspecified address, i.e. explicitly allows everything.
>
> Yoshifuji-san, can you ack that one?
>
> Signed-off-by: Arnaud Ebalard <arno@natisbad.org>
I've reviewed this and it definitely looks correct to me.
Applied, thanks Arnaud.
prev parent reply other threads:[~2010-07-18 22:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-16 10:38 [PATCH] IPv6: fix CoA check in RH2 input handler (mip6_rthdr_input()) Arnaud Ebalard
2010-07-18 22:05 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100718.150503.267945037.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arno@natisbad.org \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).