From: David Miller <davem@davemloft.net>
To: segooon@gmail.com
Cc: kernel-janitors@vger.kernel.org, acme@ghostprotocols.net,
gerrit@erg.abdn.ac.uk, dccp@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH 5/5] net: dccp: fix sign bug
Date: Sun, 18 Jul 2010 15:07:34 -0700 (PDT) [thread overview]
Message-ID: <20100718.150734.22057785.davem@davemloft.net> (raw)
In-Reply-To: <1279380060-15394-1-git-send-email-segooon@gmail.com>
From: Kulikov Vasiliy <segooon@gmail.com>
Date: Sat, 17 Jul 2010 19:21:00 +0400
> 'gap' is unsigned, so this code is wrong:
>
> gap = -new_head;
> ...
> if (gap > 0) { ... }
>
> Make 'gap' signed.
>
>
> The semantic patch that finds this problem (many false-positive results):
> (http://coccinelle.lip6.fr/)
...
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Applied, thanks.
prev parent reply other threads:[~2010-07-18 22:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-17 15:21 [PATCH 5/5] net: dccp: fix sign bug Kulikov Vasiliy
2010-07-18 22:07 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100718.150734.22057785.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=acme@ghostprotocols.net \
--cc=dccp@vger.kernel.org \
--cc=gerrit@erg.abdn.ac.uk \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=segooon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox