From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: mchan@broadcom.com, pedro.netdev@dondevamos.com,
netdev@vger.kernel.org, kaber@trash.net,
bhutchings@solarflare.com
Subject: Re: [BUG net-next-2.6] vlan, bonding, bnx2 problems
Date: Mon, 19 Jul 2010 09:35:03 -0700 (PDT) [thread overview]
Message-ID: <20100719.093503.236223875.davem@davemloft.net> (raw)
In-Reply-To: <1279545854.2553.37.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 19 Jul 2010 15:24:14 +0200
> [RFC net-next-2.6] bonding: fix bond_inet6addr_event()
>
> After commit ad1afb0039391 (vlan_dev: VLAN 0 should be treated
> as "no vlan tag" (802.1p packet)),
> bond_inet6addr_event() might be called with a NULL bond->vlgrp pointer, and
> a non empty bond->vlan_list. vlan_group_get_device() is dereferencing a NULL pointer.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
I'll apply this bandaid for now, but yes we need to think more
deeply about this.
next prev parent reply other threads:[~2010-07-19 16:34 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-13 19:20 [PATCH] vlan_dev: VLAN 0 should be treated as "no vlan tag" (802.1p packet) Pedro Garcia
2010-06-13 21:56 ` Ben Hutchings
2010-06-14 16:49 ` Pedro Garcia
2010-06-14 17:02 ` Ben Hutchings
2010-06-14 17:11 ` Patrick McHardy
2010-06-14 19:12 ` Eric Dumazet
2010-06-16 8:49 ` Pedro Garcia
2010-06-16 9:08 ` Eric Dumazet
2010-06-16 11:42 ` Patrick McHardy
2010-06-16 13:28 ` Pedro Garcia
2010-06-16 14:24 ` Arnd Bergmann
2010-06-16 15:28 ` Patrick McHardy
2010-06-16 18:26 ` Arnd Bergmann
2010-06-16 18:58 ` Eric Dumazet
2010-06-17 8:56 ` Vladislav Zolotarov
2010-06-17 10:28 ` Eric Dumazet
2010-06-17 14:08 ` Vladislav Zolotarov
2010-06-16 14:24 ` Eric Dumazet
2010-06-27 23:21 ` Pedro Garcia
2010-06-30 20:16 ` David Miller
2010-07-01 18:47 ` Pedro Garcia
2010-07-01 20:19 ` Eric Dumazet
2010-07-18 16:43 ` Pedro Garcia
2010-07-18 22:39 ` David Miller
2010-07-19 13:24 ` [BUG net-next-2.6] vlan, bonding, bnx2 problems Eric Dumazet
2010-07-19 16:35 ` David Miller [this message]
2010-07-19 18:14 ` Michael Chan
2010-07-19 20:19 ` Jay Vosburgh
2010-07-20 22:58 ` Jay Vosburgh
2010-06-24 18:28 ` [PATCH] vlan_dev: VLAN 0 should be treated as "no vlan tag" (802.1p packet) Pedro Garcia Pelaez
2010-07-08 12:54 ` Vladislav Zolotarov
2010-07-08 12:58 ` Vladislav Zolotarov
2010-07-08 13:51 ` Vladislav Zolotarov
2010-06-14 19:42 ` Joe Perches
2010-06-14 20:03 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100719.093503.236223875.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=eric.dumazet@gmail.com \
--cc=kaber@trash.net \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pedro.netdev@dondevamos.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).