From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: billfink@mindspring.com, jeffrey.t.kirsher@intel.com,
netdev@vger.kernel.org, gospo@redhat.com, bphilips@novell.com,
alexander.h.duyck@intel.com, donald.c.skidmore@intel.com
Subject: Re: [net-next-2.6 PATCH 2/5] ixgbe: drop support for UDP in RSS hash generation
Date: Mon, 19 Jul 2010 23:39:47 -0700 (PDT) [thread overview]
Message-ID: <20100719.233947.66752494.davem@davemloft.net> (raw)
In-Reply-To: <1279607400.2458.76.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 20 Jul 2010 08:30:00 +0200
> By nature, UDP flows are subject to out of order issues, so what is this
> patch tries to avoid ?
UDP being subject to out-of-order issues really doesn't matter one
bit.
We should never, _knowingly_ create out-of-order packets in our
networking stack. And this is regardless of protocol.
If there is no way to make ixgbe respect in-order packet delivery for
UDP frames vis-a-vis fragmented frames, we must disable RX flow
spreading for UDP.
next prev parent reply other threads:[~2010-07-20 6:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-19 23:59 [net-next-2.6 PATCH 1/5] ixgbe: dcb, set DPF bit when PFC is enabled Jeff Kirsher
2010-07-19 23:59 ` [net-next-2.6 PATCH 2/5] ixgbe: drop support for UDP in RSS hash generation Jeff Kirsher
2010-07-20 3:24 ` David Miller
2010-07-20 6:07 ` Bill Fink
2010-07-20 6:30 ` Eric Dumazet
2010-07-20 6:39 ` David Miller [this message]
2010-07-20 6:39 ` Eric Dumazet
2010-07-20 6:44 ` David Miller
2010-07-20 16:11 ` Alexander Duyck
2010-07-20 16:39 ` Eric Dumazet
2010-07-19 23:59 ` [net-next-2.6 PATCH 3/5] ixgbe: properly toggling netdev feature flags when disabling FCoE Jeff Kirsher
2010-07-20 3:24 ` David Miller
2010-07-20 0:00 ` [net-next-2.6 PATCH 4/5] ixgbe: use GFP_ATOMIC when allocating FCoE DDP context from the dma pool Jeff Kirsher
2010-07-20 3:24 ` David Miller
2010-07-20 0:00 ` [net-next-2.6 PATCH 5/5] ixgbe: fix version string for ixgbe Jeff Kirsher
2010-07-20 3:24 ` David Miller
2010-07-20 3:24 ` [net-next-2.6 PATCH 1/5] ixgbe: dcb, set DPF bit when PFC is enabled David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100719.233947.66752494.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexander.h.duyck@intel.com \
--cc=billfink@mindspring.com \
--cc=bphilips@novell.com \
--cc=donald.c.skidmore@intel.com \
--cc=eric.dumazet@gmail.com \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).