From: Andrew Morton <akpm@linux-foundation.org>
To: David Miller <davem@davemloft.net>
Cc: David.Choi@Micrel.Com, netdev@vger.kernel.org,
Charles.Li@Micrel.Com, horms@verge.net.au
Subject: Re: [PATCH v4 2.6.35-rc3] drivers/net: ks8842 driver
Date: Mon, 19 Jul 2010 15:45:00 -0700 [thread overview]
Message-ID: <20100719154500.a7cc2fb7.akpm@linux-foundation.org> (raw)
In-Reply-To: <20100719.152621.93431422.davem@davemloft.net>
On Mon, 19 Jul 2010 15:26:21 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:
> David Choi, I'm quite upset, this shows that you did not test the
> 16-bit code paths (the whole _point_ of this change) at all.
The code could have passed runtime testing by luck.
> You didn't even validate the build for new warnings.
yeah. The kernel build is such a stinky mess of warnings that it's
easy to miss new ones. You're basically forced to manually compile the
files which you touched to see if you added warnings.
That's pretty easy to do:
- unapply your patch
- make
- apply your patch
- make
and `make' will go and build just the files you affected.
We really should be more aggressive about all those warnings though.
prev parent reply other threads:[~2010-07-19 22:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-13 15:42 [PATCH v4 2.6.35-rc3] drivers/net: ks8842 driver Choi, David
2010-07-13 17:14 ` David Miller
2010-07-19 22:17 ` Andrew Morton
2010-07-19 22:26 ` David Miller
2010-07-19 22:45 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100719154500.a7cc2fb7.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=Charles.Li@Micrel.Com \
--cc=David.Choi@Micrel.Com \
--cc=davem@davemloft.net \
--cc=horms@verge.net.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).