From: David Miller <davem@davemloft.net>
To: nhorman@tuxdriver.com
Cc: netdev@vger.kernel.org, viro@zeniv.linux.org.uk, eparis@redhat.com
Subject: Re: [PATCH] drop_monitor: convert some kfree_skb call sites to consume_skb
Date: Tue, 20 Jul 2010 13:28:21 -0700 (PDT) [thread overview]
Message-ID: <20100720.132821.221599763.davem@davemloft.net> (raw)
In-Reply-To: <20100720164556.GF1995@hmsreliant.think-freely.org>
From: Neil Horman <nhorman@tuxdriver.com>
Date: Tue, 20 Jul 2010 12:45:56 -0400
> Convert a few calls from kfree_skb to consume_skb
>
> Noticed while I was working on dropwatch that I was detecting lots of internal
> skb drops in several places. While some are legitimate, several were not,
> freeing skbs that were at the end of their life, rather than being discarded due
> to an error. This patch converts those calls sites from using kfree_skb to
> consume_skb, which quiets the in-kernel drop_monitor code from detecting them as
> drops. Tested successfully by myself
>
> Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
Applied.
prev parent reply other threads:[~2010-07-20 20:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-20 16:45 [PATCH] drop_monitor: convert some kfree_skb call sites to consume_skb Neil Horman
2010-07-20 20:28 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100720.132821.221599763.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eparis@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).